You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chengwei Yang <ch...@gmail.com> on 2014/04/15 10:06:46 UTC
Review Request 20364: post-reviews.py: handle working on master branch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/
-----------------------------------------------------------
Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
post-reviews.py: handle working on master branch
This is a small fix but wanted most by me, whenever working on master
branch directly with small patches, rather than a dedicate branch,
post-reviews.py doesn't handle this situation but just fail with the
trace back like:
% ./support/post-reviews.py
Running post-review across all of ...
Traceback (most recent call last):
File "./support/post-reviews.py", line 104, in <module>
sha = line.split()[0]
IndexError: list index out of range
This is not quite user friendly or make a lot of sense. This patch will
handle the above situation and notice user useful information.
Diffs
-----
support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
Diff: https://reviews.apache.org/r/20364/diff/
Testing
-------
done.
Thanks,
Chengwei Yang
Re: Review Request 20364: post-reviews.py: handle working on master branch
Posted by Chengwei Yang <ch...@gmail.com>.
> On April 16, 2014, 12:46 a.m., Benjamin Hindman wrote:
> > support/post-reviews.py, lines 101-103
> > <https://reviews.apache.org/r/20364/diff/1/?file=557924#file557924line101>
> >
> > I think this is fine, but what about also checking if you're on the master branch and giving a nice error message that says we're expecting you to be working on another branch from master? Thanks for making the tools easier to use Chengwei!
Yeah, that's great, I was thinking about adding such message, but I also thought "no new change compare with master branch!" also means you should not work on master branch, because if so, it always no new change from master. :-), OK, I'd like upload a new version with your comments, that's more straight forward.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/#review40401
-----------------------------------------------------------
On April 16, 2014, 1:18 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20364/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 1:18 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> post-reviews.py: handle working on master branch
>
> This is a small fix but wanted most by me, whenever working on master
> branch directly with small patches, rather than a dedicate branch,
> post-reviews.py doesn't handle this situation but just fail with the
> trace back like:
>
> % ./support/post-reviews.py
> Running post-review across all of ...
> Traceback (most recent call last):
> File "./support/post-reviews.py", line 104, in <module>
> sha = line.split()[0]
> IndexError: list index out of range
>
> This is not quite user friendly or make a lot of sense. This patch will
> handle the above situation and notice user useful information.
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20364/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20364: post-reviews.py: handle working on master branch
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/#review40401
-----------------------------------------------------------
Ship it!
support/post-reviews.py
<https://reviews.apache.org/r/20364/#comment73378>
I think this is fine, but what about also checking if you're on the master branch and giving a nice error message that says we're expecting you to be working on another branch from master? Thanks for making the tools easier to use Chengwei!
- Benjamin Hindman
On April 15, 2014, 8:06 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20364/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 8:06 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> post-reviews.py: handle working on master branch
>
> This is a small fix but wanted most by me, whenever working on master
> branch directly with small patches, rather than a dedicate branch,
> post-reviews.py doesn't handle this situation but just fail with the
> trace back like:
>
> % ./support/post-reviews.py
> Running post-review across all of ...
> Traceback (most recent call last):
> File "./support/post-reviews.py", line 104, in <module>
> sha = line.split()[0]
> IndexError: list index out of range
>
> This is not quite user friendly or make a lot of sense. This patch will
> handle the above situation and notice user useful information.
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20364/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20364: post-reviews.py: handle working on master branch
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/#review40365
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20364]
All tests passed.
- Mesos ReviewBot
On April 15, 2014, 8:06 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20364/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 8:06 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> post-reviews.py: handle working on master branch
>
> This is a small fix but wanted most by me, whenever working on master
> branch directly with small patches, rather than a dedicate branch,
> post-reviews.py doesn't handle this situation but just fail with the
> trace back like:
>
> % ./support/post-reviews.py
> Running post-review across all of ...
> Traceback (most recent call last):
> File "./support/post-reviews.py", line 104, in <module>
> sha = line.split()[0]
> IndexError: list index out of range
>
> This is not quite user friendly or make a lot of sense. This patch will
> handle the above situation and notice user useful information.
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20364/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20364: post-reviews.py: handle working on master branch
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/#review40554
-----------------------------------------------------------
Ship it!
Will get this committed now, thanks!
- Benjamin Hindman
On April 16, 2014, 2:01 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20364/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 2:01 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> post-reviews.py: handle working on master branch
>
> This is a small fix but wanted most by me, whenever working on master
> branch directly with small patches, rather than a dedicate branch,
> post-reviews.py doesn't handle this situation but just fail with the
> trace back like:
>
> % ./support/post-reviews.py
> Running post-review across all of ...
> Traceback (most recent call last):
> File "./support/post-reviews.py", line 104, in <module>
> sha = line.split()[0]
> IndexError: list index out of range
>
> This is not quite user friendly or make a lot of sense. This patch will
> handle the above situation and notice user useful information.
>
> Review: https://reviews.apache.org/r/20364
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20364/diff/
>
>
> Testing
> -------
>
> done.
>
> assuming working on master branch
> % ./support/post-reviews.py
> we're expecting you to be working on another branch from master!
>
> assuming branch A is the same as master.
> % ./support/post-reviews.py
> Running post-review across all of ...
> No new change compare with master branch!
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20364: post-reviews.py: handle working on master branch
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/#review40547
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20364]
All tests passed.
- Mesos ReviewBot
On April 16, 2014, 2:01 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20364/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 2:01 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> post-reviews.py: handle working on master branch
>
> This is a small fix but wanted most by me, whenever working on master
> branch directly with small patches, rather than a dedicate branch,
> post-reviews.py doesn't handle this situation but just fail with the
> trace back like:
>
> % ./support/post-reviews.py
> Running post-review across all of ...
> Traceback (most recent call last):
> File "./support/post-reviews.py", line 104, in <module>
> sha = line.split()[0]
> IndexError: list index out of range
>
> This is not quite user friendly or make a lot of sense. This patch will
> handle the above situation and notice user useful information.
>
> Review: https://reviews.apache.org/r/20364
>
>
> Diffs
> -----
>
> support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
>
> Diff: https://reviews.apache.org/r/20364/diff/
>
>
> Testing
> -------
>
> done.
>
> assuming working on master branch
> % ./support/post-reviews.py
> we're expecting you to be working on another branch from master!
>
> assuming branch A is the same as master.
> % ./support/post-reviews.py
> Running post-review across all of ...
> No new change compare with master branch!
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20364: post-reviews.py: handle working on master branch
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/
-----------------------------------------------------------
(Updated April 16, 2014, 10:01 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
make sure we're not working on master branch first.
Repository: mesos-git
Description (updated)
-------
post-reviews.py: handle working on master branch
This is a small fix but wanted most by me, whenever working on master
branch directly with small patches, rather than a dedicate branch,
post-reviews.py doesn't handle this situation but just fail with the
trace back like:
% ./support/post-reviews.py
Running post-review across all of ...
Traceback (most recent call last):
File "./support/post-reviews.py", line 104, in <module>
sha = line.split()[0]
IndexError: list index out of range
This is not quite user friendly or make a lot of sense. This patch will
handle the above situation and notice user useful information.
Review: https://reviews.apache.org/r/20364
Diffs (updated)
-----
support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
Diff: https://reviews.apache.org/r/20364/diff/
Testing (updated)
-------
done.
assuming working on master branch
% ./support/post-reviews.py
we're expecting you to be working on another branch from master!
assuming branch A is the same as master.
% ./support/post-reviews.py
Running post-review across all of ...
No new change compare with master branch!
Thanks,
Chengwei Yang
Re: Review Request 20364: post-reviews.py: handle working on master branch
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/
-----------------------------------------------------------
(Updated April 15, 2014, 5:18 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
assigning to @benh to shepherd -- Vinod
Repository: mesos-git
Description
-------
post-reviews.py: handle working on master branch
This is a small fix but wanted most by me, whenever working on master
branch directly with small patches, rather than a dedicate branch,
post-reviews.py doesn't handle this situation but just fail with the
trace back like:
% ./support/post-reviews.py
Running post-review across all of ...
Traceback (most recent call last):
File "./support/post-reviews.py", line 104, in <module>
sha = line.split()[0]
IndexError: list index out of range
This is not quite user friendly or make a lot of sense. This patch will
handle the above situation and notice user useful information.
Diffs
-----
support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d
Diff: https://reviews.apache.org/r/20364/diff/
Testing
-------
done.
Thanks,
Chengwei Yang