You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/02 03:55:40 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #884: FIX - Update physical network labels
utchoang opened a new pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884
Fixes #882
@rhtyd cc @svenvogel Please review it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r534038067
##########
File path: src/views/infra/network/EditTrafficLabel.vue
##########
@@ -0,0 +1,235 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-spin :spinning="loading">
+ <a-form :form="form" :loading="loading" @submit="handleSubmit" layout="vertical">
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.id') }}
Review comment:
Would be better to mention traffic type rather than id
```suggestion
{{ $t('label.traffictype') }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737661260
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-736978865
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/884 (JID-3709)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737028582
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/884 (JID-3711)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r534038067
##########
File path: src/views/infra/network/EditTrafficLabel.vue
##########
@@ -0,0 +1,235 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-spin :spinning="loading">
+ <a-form :form="form" :loading="loading" @submit="handleSubmit" layout="vertical">
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.id') }}
Review comment:
```suggestion
{{ $t('label.traffictype') }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r534016321
##########
File path: src/views/infra/network/EditTrafficLabel.vue
##########
@@ -0,0 +1,235 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-spin :spinning="loading">
+ <a-form :form="form" :loading="loading" @submit="handleSubmit" layout="vertical">
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.id') }}
+ <a-tooltip :title="apiParams.id.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-select
+ v-decorator="['id', {
+ initialValue: selectedType,
+ rules: [{ required: true, message: $t('message.error.select') }] }]"
+ :loading="typeLoading"
+ :placeholder="apiParams.id.description"
+ @change="onChangeTrafficType">
+ <a-select-option v-for="type in trafficTypes" :key="type.id">
+ {{ type.traffictype }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.kvmnetworklabel') }}
+ <a-tooltip :title="apiParams.kvmnetworklabel.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-input
+ v-decorator="['kvmnetworklabel', {
+ initialValue: trafficResource.kvmnetworklabel
+ }]"
+ :placeholder="$t('label.network.label.display.for.blank.value')" />
+ </a-form-item>
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.vmwarenetworklabel') }}
+ <a-tooltip :title="apiParams.vmwarenetworklabel.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-input
+ v-decorator="['vmwarenetworklabel', {
+ initialValue: trafficResource.vmwarenetworklabel
+ }]"
+ :placeholder="$t('label.network.label.display.for.blank.value')" />
+ </a-form-item>
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.xennetworklabel') }}
+ <a-tooltip :title="apiParams.xennetworklabel.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-input
+ v-decorator="['xennetworklabel', {
+ initialValue: trafficResource.xennetworklabel
+ }]"
+ :placeholder="$t('label.network.label.display.for.blank.value')" />
+ </a-form-item>
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.hypervnetworklabel') }}
+ <a-tooltip :title="apiParams.hypervnetworklabel.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-input
+ v-decorator="['hypervnetworklabel', {
+ initialValue: trafficResource.hypervnetworklabel
+ }]"
+ :placeholder="$t('label.network.label.display.for.blank.value')" />
+ </a-form-item>
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.ovm3networklabel') }}
+ <a-tooltip :title="apiParams.ovm3networklabel.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-input
+ v-decorator="['ovm3networklabel', {
+ initialValue: trafficResource.ovm3networklabel
+ }]"
+ :placeholder="$t('label.network.label.display.for.blank.value')" />
+ </a-form-item>
+ <div :span="24" class="action-button">
+ <a-button @click="closeAction">{{ $t('label.cancel') }}</a-button>
+ <a-button :loading="loading" type="primary" @click="handleSubmit">{{ $t('label.ok') }}</a-button>
+ </div>
+ </a-form>
+ </a-spin>
+ </div>
+</template>
+
+<script>
+import { api } from '@/api'
+
+export default {
+ name: 'EditTrafficLabel',
+ props: {
+ resource: {
+ type: Object,
+ default: () => {}
+ }
+ },
+ data () {
+ return {
+ loading: false,
+ selectedType: undefined,
+ typeLoading: false,
+ traffictype: null,
+ trafficTypes: [],
+ trafficResource: {}
+ }
+ },
+ beforeCreate () {
+ this.form = this.$form.createForm(this)
+ this.apiConfig = this.$store.getters.apis.updateTrafficType || {}
+ this.apiParams = {}
+ if (this.apiConfig.params) {
+ this.apiConfig.params.forEach(param => {
+ this.apiParams[param.name] = param
+ })
+ }
+ },
+ inject: ['parentFetchData'],
+ mounted () {
+ this.fetchData()
+ },
+ methods: {
+ fetchData () {
+ this.typeLoading = true
+
+ api('listTrafficTypes', { physicalnetworkid: this.resource.id })
+ .then(json => {
+ this.trafficTypes = json.listtraffictypesresponse.traffictype || []
+ this.selectedType = this.trafficTypes[0].id || undefined
+ this.trafficResource = this.trafficTypes[0] || {}
+ this.traffictype = this.trafficTypes[0].traffictype || undefined
+ })
+ .catch(error => {
+ this.$notification.error({
+ message: `${this.$t('label.error')} ${error.response.status}`,
+ description: error.response.data.errorresponse.errortext
+ })
+ })
+ .finally(() => {
+ this.typeLoading = false
+ })
+ },
+ onChangeTrafficType (trafficId) {
+ if (!trafficId) return
+ this.trafficResource = this.trafficTypes.filter(item => item.id === trafficId)[0] || {}
+ this.traffictype = this.trafficResource.traffictype || undefined
+ },
+ handleSubmit (e) {
+ e.preventDefault()
+ this.form.validateFields((err, values) => {
+ if (err) {
+ return
+ }
+ this.loading = true
+ const params = {}
+ for (const key in values) {
+ params[key] = values[key] ? values[key].trim() : undefined
Review comment:
@utchoang Unable to reset the traffic label. Think removing this check might fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737023598
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737109759
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-736976163
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737708116
LGTM, tested few cases with different traffic types. Existing values seen populated in the update form:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r533898531
##########
File path: src/views/infra/network/EditTrafficLabel.vue
##########
@@ -0,0 +1,241 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-spin :spinning="loading">
+ <a-form :form="form" :loading="loading" @submit="handleSubmit" layout="vertical">
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.id') }}
+ <a-tooltip :title="apiParams.id.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-select
+ v-decorator="['id', {
+ initialValue: selectedType,
+ rules: [{ required: true, message: $t('message.error.select') }] }]"
+ :loading="typeLoading"
+ :placeholder="apiParams.id.description"
+ @change="onChangeTrafficType">
+ <a-select-option v-for="type in trafficTypes" :key="type.id">
+ {{ type.traffictype }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.kvmnetworklabel') }}
+ <a-tooltip :title="apiParams.kvmnetworklabel.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-input
+ v-decorator="['kvmnetworklabel', {
+ initialValue: trafficResource.kvmnetworklabel || $t('label.network.label.display.for.blank.value')
Review comment:
@utchoang Would it be better to use `$t('label.network.label.display.for.blank.value')` as a placeholder instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-736976492
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737110276
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737663870
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/884 (JID-3716)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737023997
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737661019
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737115428
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/884 (JID-3712)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #884:
URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r533898531
##########
File path: src/views/infra/network/EditTrafficLabel.vue
##########
@@ -0,0 +1,241 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-spin :spinning="loading">
+ <a-form :form="form" :loading="loading" @submit="handleSubmit" layout="vertical">
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.id') }}
+ <a-tooltip :title="apiParams.id.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-select
+ v-decorator="['id', {
+ initialValue: selectedType,
+ rules: [{ required: true, message: $t('message.error.select') }] }]"
+ :loading="typeLoading"
+ :placeholder="apiParams.id.description"
+ @change="onChangeTrafficType">
+ <a-select-option v-for="type in trafficTypes" :key="type.id">
+ {{ type.traffictype }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
+ <a-form-item>
+ <span slot="label">
+ {{ $t('label.kvmnetworklabel') }}
+ <a-tooltip :title="apiParams.kvmnetworklabel.description">
+ <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
+ </a-tooltip>
+ </span>
+ <a-input
+ v-decorator="['kvmnetworklabel', {
+ initialValue: trafficResource.kvmnetworklabel || $t('label.network.label.display.for.blank.value')
Review comment:
@utchoang Would it be better to use `$t('label.network.label.display.for.blank.value')` as a placeholder instead?
Also the user is unable to clear or reset the tag once it's been set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org