You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@atlas.apache.org by ve...@apache.org on 2015/09/12 00:52:45 UTC

[08/11] incubator-atlas git commit: ATLAS-152 TimeStamp fields not showing the details tab. Contributed by Vishal Kadam

ATLAS-152 TimeStamp fields not showing the details tab. Contributed by Vishal Kadam


Project: http://git-wip-us.apache.org/repos/asf/incubator-atlas/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/ff5b1f17
Tree: http://git-wip-us.apache.org/repos/asf/incubator-atlas/tree/ff5b1f17
Diff: http://git-wip-us.apache.org/repos/asf/incubator-atlas/diff/ff5b1f17

Branch: refs/heads/master
Commit: ff5b1f172b18442c404db949f657e3f8e1317327
Parents: d1eef49
Author: Venkatesh Seetharam <ve...@apache.org>
Authored: Fri Sep 11 15:14:24 2015 -0700
Committer: Venkatesh Seetharam <ve...@apache.org>
Committed: Fri Sep 11 15:14:24 2015 -0700

----------------------------------------------------------------------
 dashboard/public/modules/details/detailsController.js | 2 ++
 dashboard/public/modules/details/views/details.html   | 8 ++++----
 release-log.txt                                       | 5 +++--
 3 files changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/ff5b1f17/dashboard/public/modules/details/detailsController.js
----------------------------------------------------------------------
diff --git a/dashboard/public/modules/details/detailsController.js b/dashboard/public/modules/details/detailsController.js
index 0e96d42..7bfed9b 100644
--- a/dashboard/public/modules/details/detailsController.js
+++ b/dashboard/public/modules/details/detailsController.js
@@ -33,6 +33,8 @@ angular.module('dgc.details').controller('DetailsController', ['$window', '$scop
             $scope.isTable = data.typeName === 'Table';
         });
 
+        $scope.isNumber = angular.isNumber;
+        
         $scope.isString = angular.isString;
 
         $scope.onActivate = function tabActivate(tabname) {

http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/ff5b1f17/dashboard/public/modules/details/views/details.html
----------------------------------------------------------------------
diff --git a/dashboard/public/modules/details/views/details.html b/dashboard/public/modules/details/views/details.html
index 19f0ce0..c0419cb 100644
--- a/dashboard/public/modules/details/views/details.html
+++ b/dashboard/public/modules/details/views/details.html
@@ -33,10 +33,10 @@
                     </tr>
                     </thead>
                     <tbody>
-                    <tr data-ng-repeat="(key,value) in details.values" ng-if="value && !(key==='columns') && !(key==='name') && !(key==='description')">
-                        <td>{{key}}</td>
-                        <td data-ng-if="!isString(value)" data-ng-include="'/modules/details/views/attribute.html'"></td>
-                        <td data-ng-if="isString(value)">{{value | date:'medium'}}</td>
+                   <tr data-ng-repeat="(key,value) in details.values" ng-if="value && !(key==='columns') && !(key==='name') && !(key==='description')">
+                        <td>{{key}}</td>   
+                        <td data-ng-if="!isString(value) && !isNumber(value)" data-ng-include="'/modules/details/views/attribute.html'"></td>
+                        <td data-ng-if="isString(value) || isNumber(value)">{{value | date:'medium'}}</td> 
                     </tr>
                     </tbody>
                 </table>

http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/ff5b1f17/release-log.txt
----------------------------------------------------------------------
diff --git a/release-log.txt b/release-log.txt
index babfa10..dd50765 100644
--- a/release-log.txt
+++ b/release-log.txt
@@ -8,8 +8,9 @@ ATLAS-54 Rename configs in hive hook (shwethags)
 ATLAS-3 Mixed Index creation fails with Date types (suma.shivaprasad via shwethags)
 
 ALL CHANGES:
-ATLAS-111
-UI: Create Help Link  (Vishal Kadam via Venkatesh Seetharam)
+ATLAS-152 TimeStamp fields not showing the details tab (Vishal Kadam
+via Venkatesh Seetharam)
+ATLAS-111 UI: Create Help Link (Vishal Kadam via Venkatesh Seetharam)
 ATLAS-113 Add an About Dialog to Apache Atlas UI with version number (Vishal Kadam
 via Venkatesh Seetharam)
 ATLAS-109 Remove v2 Folder (Vishal Kadam via Venkatesh Seetharam)