You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tom Copeland <to...@infoether.com> on 2003/06/16 23:09:04 UTC
[Fwd: A proposed change to the PMD plugin....]
Hearing no objections.... this change is checked in now.
Thanks,
Tom
-----Forwarded Message-----
> From: Tom Copeland <to...@infoether.com>
> To: dev@maven.apache.org
> Subject: A proposed change to the PMD plugin....
> Date: 16 Jun 2003 15:58:09 -0400
>
> ....I'd like to check in a change to
> maven/src/plugins-build/pmd/plugin.properties - I'd like to reduce the
> standard set of rulesets to basic.xml, unusedcode.xml, and imports.xml.
>
> Here's why - right now the PMD plugin runs every ruleset that PMD has.
> This includes rulesets that have conflicting rules - for example, the
> controversial.xml ruleset has one rule that requires every class have at
> least one constructor and another rule that looks for unnecessary
> constructors. So by running every rule in the controversial ruleset,
> you're guaranteed to get a bunch of rule violations no matter what you
> do.
>
> I'd have simply checked this in, but I haven't been active in Maven for
> a while and wanted to make sure I wasn't hosing anything up first.
> Here's a patch for what I'd like to check in:
>
> =================
> [tom@hal pmd]$ cvs diff plugin.properties
> Index: plugin.properties
> ===================================================================
> RCS file: /home/cvs/maven/src/plugins-build/pmd/plugin.properties,v
> retrieving revision 1.2
> diff -r1.2 plugin.properties
> 14c14
> <
> maven.pmd.rulesetfiles=${plugin.resources}/rulesets/strings.xml,${plugin.resources}/rulesets/junit.xml,${plugin.resources}/rulesets/braces.xml,${plugin.resources}/rulesets/basic.xml,${plugin.resources}/rulesets/unusedcode.xml,${plugin.resources}/rulesets/design.xml,${plugin.resources}/rulesets/naming.xml,${plugin.resources}/rulesets/imports.xml,${plugin.resources}/rulesets/codesize.xml
> ---
> >
> maven.pmd.rulesetfiles=${plugin.resources}/rulesets/basic.xml,${plugin.resources}/rulesets/unusedcode.xml,${plugin.resources}/rulesets/imports.xml
> [tom@hal pmd]$
> =================
>
> If no one has any objections, I'll check this updated plugins.properties
> in in a little while...
>
> Thanks much,
>
> Tom
> --
> Tom Copeland <to...@infoether.com>
> InfoEther
--
Tom Copeland <to...@infoether.com>
InfoEther
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [Fwd: A proposed change to the PMD plugin....]
Posted by tom <to...@infoether.com>.
Actually, I should have waited for some +1s.... sorry about that....
Yours,
Tom
> -----Original Message-----
> From: Vincent Massol [mailto:vmassol@pivolis.com]
> Sent: Tuesday, June 17, 2003 12:52 AM
> To: 'Maven Developers List'
> Subject: RE: [Fwd: A proposed change to the PMD plugin....]
>
>
> +1 (a bit late)
>
> -Vincent
>
> > -----Original Message-----
> > From: Tom Copeland [mailto:tom@infoether.com]
> > Sent: 16 June 2003 23:09
> > To: dev@maven.apache.org
> > Subject: [Fwd: A proposed change to the PMD plugin....]
> >
> > Hearing no objections.... this change is checked in now.
> >
> > Thanks,
> >
> > Tom
> >
> > -----Forwarded Message-----
> >
> > > From: Tom Copeland <to...@infoether.com>
> > > To: dev@maven.apache.org
> > > Subject: A proposed change to the PMD plugin....
> > > Date: 16 Jun 2003 15:58:09 -0400
> > >
> > > ....I'd like to check in a change to
> > > maven/src/plugins-build/pmd/plugin.properties - I'd like to reduce
> the
> > > standard set of rulesets to basic.xml, unusedcode.xml, and
> imports.xml.
> > >
> > > Here's why - right now the PMD plugin runs every ruleset that PMD
> has.
> > > This includes rulesets that have conflicting rules - for example,
> the
> > > controversial.xml ruleset has one rule that requires every class
> have at
> > > least one constructor and another rule that looks for unnecessary
> > > constructors. So by running every rule in the controversial
> ruleset,
> > > you're guaranteed to get a bunch of rule violations no matter what
> you
> > > do.
> > >
> > > I'd have simply checked this in, but I haven't been
> active in Maven
> for
> > > a while and wanted to make sure I wasn't hosing anything up first.
> > > Here's a patch for what I'd like to check in:
> > >
> > > =================
> > > [tom@hal pmd]$ cvs diff plugin.properties
> > > Index: plugin.properties
> > >
> ===================================================================
> > > RCS file:
> /home/cvs/maven/src/plugins-build/pmd/plugin.properties,v
> > > retrieving revision 1.2
> > > diff -r1.2 plugin.properties
> > > 14c14
> > > <
> > >
> >
> maven.pmd.rulesetfiles=${plugin.resources}/rulesets/strings.xm
> l,${plugin
> .r
> >
> esources}/rulesets/junit.xml,${plugin.resources}/rulesets/brac
> es.xml,${p
> lu
> >
> gin.resources}/rulesets/basic.xml,${plugin.resources}/rulesets
> /unusedcod
> e.
> >
> xml,${plugin.resources}/rulesets/design.xml,${plugin.resources
> }/rulesets
> /n
> >
> aming.xml,${plugin.resources}/rulesets/imports.xml,${plugin.re
> sources}/r
> ul
> > esets/codesize.xml
> > > ---
> > > >
> > >
> >
> maven.pmd.rulesetfiles=${plugin.resources}/rulesets/basic.xml,
> ${plugin.r
> es
> >
> ources}/rulesets/unusedcode.xml,${plugin.resources}/rulesets/i
> mports.xml
> > > [tom@hal pmd]$
> > > =================
> > >
> > > If no one has any objections, I'll check this updated
> plugins.properties
> > > in in a little while...
> > >
> > > Thanks much,
> > >
> > > Tom
> > > --
> > > Tom Copeland <to...@infoether.com>
> > > InfoEther
> > --
> > Tom Copeland <to...@infoether.com>
> > InfoEther
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [Fwd: A proposed change to the PMD plugin....]
Posted by Vincent Massol <vm...@pivolis.com>.
+1 (a bit late)
-Vincent
> -----Original Message-----
> From: Tom Copeland [mailto:tom@infoether.com]
> Sent: 16 June 2003 23:09
> To: dev@maven.apache.org
> Subject: [Fwd: A proposed change to the PMD plugin....]
>
> Hearing no objections.... this change is checked in now.
>
> Thanks,
>
> Tom
>
> -----Forwarded Message-----
>
> > From: Tom Copeland <to...@infoether.com>
> > To: dev@maven.apache.org
> > Subject: A proposed change to the PMD plugin....
> > Date: 16 Jun 2003 15:58:09 -0400
> >
> > ....I'd like to check in a change to
> > maven/src/plugins-build/pmd/plugin.properties - I'd like to reduce
the
> > standard set of rulesets to basic.xml, unusedcode.xml, and
imports.xml.
> >
> > Here's why - right now the PMD plugin runs every ruleset that PMD
has.
> > This includes rulesets that have conflicting rules - for example,
the
> > controversial.xml ruleset has one rule that requires every class
have at
> > least one constructor and another rule that looks for unnecessary
> > constructors. So by running every rule in the controversial
ruleset,
> > you're guaranteed to get a bunch of rule violations no matter what
you
> > do.
> >
> > I'd have simply checked this in, but I haven't been active in Maven
for
> > a while and wanted to make sure I wasn't hosing anything up first.
> > Here's a patch for what I'd like to check in:
> >
> > =================
> > [tom@hal pmd]$ cvs diff plugin.properties
> > Index: plugin.properties
> > ===================================================================
> > RCS file: /home/cvs/maven/src/plugins-build/pmd/plugin.properties,v
> > retrieving revision 1.2
> > diff -r1.2 plugin.properties
> > 14c14
> > <
> >
>
maven.pmd.rulesetfiles=${plugin.resources}/rulesets/strings.xml,${plugin
.r
>
esources}/rulesets/junit.xml,${plugin.resources}/rulesets/braces.xml,${p
lu
>
gin.resources}/rulesets/basic.xml,${plugin.resources}/rulesets/unusedcod
e.
>
xml,${plugin.resources}/rulesets/design.xml,${plugin.resources}/rulesets
/n
>
aming.xml,${plugin.resources}/rulesets/imports.xml,${plugin.resources}/r
ul
> esets/codesize.xml
> > ---
> > >
> >
>
maven.pmd.rulesetfiles=${plugin.resources}/rulesets/basic.xml,${plugin.r
es
>
ources}/rulesets/unusedcode.xml,${plugin.resources}/rulesets/imports.xml
> > [tom@hal pmd]$
> > =================
> >
> > If no one has any objections, I'll check this updated
plugins.properties
> > in in a little while...
> >
> > Thanks much,
> >
> > Tom
> > --
> > Tom Copeland <to...@infoether.com>
> > InfoEther
> --
> Tom Copeland <to...@infoether.com>
> InfoEther
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org