You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Sebastian Hennebrueder (JIRA)" <ji...@apache.org> on 2009/09/02 17:39:32 UTC
[jira] Created: (TAP5-832) Hidden input field fails with coercion
problem on empty value (patch incl)
Hidden input field fails with coercion problem on empty value (patch incl)
--------------------------------------------------------------------------
Key: TAP5-832
URL: https://issues.apache.org/jira/browse/TAP5-832
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.5, 5.2.0.0
Reporter: Sebastian Hennebrueder
If a hidden field has a blanc input "" , it fails with the following stackstrace (my Hidden component is just a copy of the orginal of 5.1.0.5)
The reason is that there is no nullfieldstrategie assigned to a hidden field as opposed to text fields. The attached patch adds such a strategie.
# org.apache.tapestry5.internal.bindings.PropBinding.set(PropBinding.java:71)
# org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl$1.write(InternalComponentResourcesImpl.java:540)
# de.laliluna.bibabook.components.Hidden._$update_parameter_value(Hidden.java)
# de.laliluna.bibabook.components.Hidden.processSubmission(Hidden.java:136)
# de.laliluna.bibabook.components.Hidden.access$000(Hidden.java:37)
# de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:94)
# de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:86)
# org.apache.tapestry5.corelib.components.Form.executeStoredActions(Form.java:480)
# org.apache.tapestry5.corelib.components.Form._$advised$onAction(Form.java:378)
# org.apache.tapestry5.corelib.components.Form$onAction$invocation_1237b3fe6bd.invokeAdvisedMethod(Form$onAction$invocation_1237b3fe6bd.java)
# org.apache.tapestry5.internal.services.AbstractComponentMethodInvocation.proceed(AbstractComponentMethodInvocation.java:71)
# org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
# org.apache.tapestry5.internal.transform.LogWorker$1.advise(LogWorker.java:54)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-832) Hidden input field fails with coercion
problem on empty value (patch incl)
Posted by "Ulrich Stärk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750508#action_12750508 ]
Ulrich Stärk commented on TAP5-832:
-----------------------------------
could you please write a test that fails if the hidden component throws an exception on a blank value?
> Hidden input field fails with coercion problem on empty value (patch incl)
> --------------------------------------------------------------------------
>
> Key: TAP5-832
> URL: https://issues.apache.org/jira/browse/TAP5-832
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0.0, 5.1.0.5
> Reporter: Sebastian Hennebrueder
> Attachments: Hidden.patch
>
>
> If a hidden field has a blanc input "" , it fails with the following stackstrace (my Hidden component is just a copy of the orginal of 5.1.0.5)
> The reason is that there is no nullfieldstrategie assigned to a hidden field as opposed to text fields. The attached patch adds such a strategie.
> # org.apache.tapestry5.internal.bindings.PropBinding.set(PropBinding.java:71)
> # org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl$1.write(InternalComponentResourcesImpl.java:540)
> # de.laliluna.bibabook.components.Hidden._$update_parameter_value(Hidden.java)
> # de.laliluna.bibabook.components.Hidden.processSubmission(Hidden.java:136)
> # de.laliluna.bibabook.components.Hidden.access$000(Hidden.java:37)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:94)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:86)
> # org.apache.tapestry5.corelib.components.Form.executeStoredActions(Form.java:480)
> # org.apache.tapestry5.corelib.components.Form._$advised$onAction(Form.java:378)
> # org.apache.tapestry5.corelib.components.Form$onAction$invocation_1237b3fe6bd.invokeAdvisedMethod(Form$onAction$invocation_1237b3fe6bd.java)
> # org.apache.tapestry5.internal.services.AbstractComponentMethodInvocation.proceed(AbstractComponentMethodInvocation.java:71)
> # org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
> # org.apache.tapestry5.internal.transform.LogWorker$1.advise(LogWorker.java:54)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-832) Hidden input field fails with coercion
problem on empty value (patch incl)
Posted by "Sebastian Hennebrueder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Hennebrueder updated TAP5-832:
----------------------------------------
Attachment: Hidden.patch
patch to 5.2 trunk
> Hidden input field fails with coercion problem on empty value (patch incl)
> --------------------------------------------------------------------------
>
> Key: TAP5-832
> URL: https://issues.apache.org/jira/browse/TAP5-832
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0.0, 5.1.0.5
> Reporter: Sebastian Hennebrueder
> Attachments: Hidden.patch
>
>
> If a hidden field has a blanc input "" , it fails with the following stackstrace (my Hidden component is just a copy of the orginal of 5.1.0.5)
> The reason is that there is no nullfieldstrategie assigned to a hidden field as opposed to text fields. The attached patch adds such a strategie.
> # org.apache.tapestry5.internal.bindings.PropBinding.set(PropBinding.java:71)
> # org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl$1.write(InternalComponentResourcesImpl.java:540)
> # de.laliluna.bibabook.components.Hidden._$update_parameter_value(Hidden.java)
> # de.laliluna.bibabook.components.Hidden.processSubmission(Hidden.java:136)
> # de.laliluna.bibabook.components.Hidden.access$000(Hidden.java:37)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:94)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:86)
> # org.apache.tapestry5.corelib.components.Form.executeStoredActions(Form.java:480)
> # org.apache.tapestry5.corelib.components.Form._$advised$onAction(Form.java:378)
> # org.apache.tapestry5.corelib.components.Form$onAction$invocation_1237b3fe6bd.invokeAdvisedMethod(Form$onAction$invocation_1237b3fe6bd.java)
> # org.apache.tapestry5.internal.services.AbstractComponentMethodInvocation.proceed(AbstractComponentMethodInvocation.java:71)
> # org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
> # org.apache.tapestry5.internal.transform.LogWorker$1.advise(LogWorker.java:54)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-832) Hidden input field fails with coercion
problem on empty value (patch incl)
Posted by "Sebastian Hennebrueder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750514#action_12750514 ]
Sebastian Hennebrueder commented on TAP5-832:
---------------------------------------------
I looked through the existing tests and I am not sure how to build the test in the most efficient manner.
Shall I use a PageTester http://tapestry.apache.org/tapestry5/guide/unit-testing-pages.html or
is there a simplere way to simulate a form submit?
> Hidden input field fails with coercion problem on empty value (patch incl)
> --------------------------------------------------------------------------
>
> Key: TAP5-832
> URL: https://issues.apache.org/jira/browse/TAP5-832
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0.0, 5.1.0.5
> Reporter: Sebastian Hennebrueder
> Attachments: Hidden.patch
>
>
> If a hidden field has a blanc input "" , it fails with the following stackstrace (my Hidden component is just a copy of the orginal of 5.1.0.5)
> The reason is that there is no nullfieldstrategie assigned to a hidden field as opposed to text fields. The attached patch adds such a strategie.
> # org.apache.tapestry5.internal.bindings.PropBinding.set(PropBinding.java:71)
> # org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl$1.write(InternalComponentResourcesImpl.java:540)
> # de.laliluna.bibabook.components.Hidden._$update_parameter_value(Hidden.java)
> # de.laliluna.bibabook.components.Hidden.processSubmission(Hidden.java:136)
> # de.laliluna.bibabook.components.Hidden.access$000(Hidden.java:37)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:94)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:86)
> # org.apache.tapestry5.corelib.components.Form.executeStoredActions(Form.java:480)
> # org.apache.tapestry5.corelib.components.Form._$advised$onAction(Form.java:378)
> # org.apache.tapestry5.corelib.components.Form$onAction$invocation_1237b3fe6bd.invokeAdvisedMethod(Form$onAction$invocation_1237b3fe6bd.java)
> # org.apache.tapestry5.internal.services.AbstractComponentMethodInvocation.proceed(AbstractComponentMethodInvocation.java:71)
> # org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
> # org.apache.tapestry5.internal.transform.LogWorker$1.advise(LogWorker.java:54)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-832) Hidden input field fails with coercion
problem on empty value (patch incl)
Posted by "Sebastian Hennebrueder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750514#action_12750514 ]
Sebastian Hennebrueder commented on TAP5-832:
---------------------------------------------
I looked through the existing tests and I am not sure how to build the test in the most efficient manner.
Shall I use a PageTester http://tapestry.apache.org/tapestry5/guide/unit-testing-pages.html or
is there a simplere way to simulate a form submit?
> Hidden input field fails with coercion problem on empty value (patch incl)
> --------------------------------------------------------------------------
>
> Key: TAP5-832
> URL: https://issues.apache.org/jira/browse/TAP5-832
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0.0, 5.1.0.5
> Reporter: Sebastian Hennebrueder
> Attachments: Hidden.patch
>
>
> If a hidden field has a blanc input "" , it fails with the following stackstrace (my Hidden component is just a copy of the orginal of 5.1.0.5)
> The reason is that there is no nullfieldstrategie assigned to a hidden field as opposed to text fields. The attached patch adds such a strategie.
> # org.apache.tapestry5.internal.bindings.PropBinding.set(PropBinding.java:71)
> # org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl$1.write(InternalComponentResourcesImpl.java:540)
> # de.laliluna.bibabook.components.Hidden._$update_parameter_value(Hidden.java)
> # de.laliluna.bibabook.components.Hidden.processSubmission(Hidden.java:136)
> # de.laliluna.bibabook.components.Hidden.access$000(Hidden.java:37)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:94)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:86)
> # org.apache.tapestry5.corelib.components.Form.executeStoredActions(Form.java:480)
> # org.apache.tapestry5.corelib.components.Form._$advised$onAction(Form.java:378)
> # org.apache.tapestry5.corelib.components.Form$onAction$invocation_1237b3fe6bd.invokeAdvisedMethod(Form$onAction$invocation_1237b3fe6bd.java)
> # org.apache.tapestry5.internal.services.AbstractComponentMethodInvocation.proceed(AbstractComponentMethodInvocation.java:71)
> # org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
> # org.apache.tapestry5.internal.transform.LogWorker$1.advise(LogWorker.java:54)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-832) Hidden input field fails with coercion
problem on empty value (patch incl)
Posted by "Ulrich Stärk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750508#action_12750508 ]
Ulrich Stärk commented on TAP5-832:
-----------------------------------
could you please write a test that fails if the hidden component throws an exception on a blank value?
> Hidden input field fails with coercion problem on empty value (patch incl)
> --------------------------------------------------------------------------
>
> Key: TAP5-832
> URL: https://issues.apache.org/jira/browse/TAP5-832
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0.0, 5.1.0.5
> Reporter: Sebastian Hennebrueder
> Attachments: Hidden.patch
>
>
> If a hidden field has a blanc input "" , it fails with the following stackstrace (my Hidden component is just a copy of the orginal of 5.1.0.5)
> The reason is that there is no nullfieldstrategie assigned to a hidden field as opposed to text fields. The attached patch adds such a strategie.
> # org.apache.tapestry5.internal.bindings.PropBinding.set(PropBinding.java:71)
> # org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl$1.write(InternalComponentResourcesImpl.java:540)
> # de.laliluna.bibabook.components.Hidden._$update_parameter_value(Hidden.java)
> # de.laliluna.bibabook.components.Hidden.processSubmission(Hidden.java:136)
> # de.laliluna.bibabook.components.Hidden.access$000(Hidden.java:37)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:94)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:86)
> # org.apache.tapestry5.corelib.components.Form.executeStoredActions(Form.java:480)
> # org.apache.tapestry5.corelib.components.Form._$advised$onAction(Form.java:378)
> # org.apache.tapestry5.corelib.components.Form$onAction$invocation_1237b3fe6bd.invokeAdvisedMethod(Form$onAction$invocation_1237b3fe6bd.java)
> # org.apache.tapestry5.internal.services.AbstractComponentMethodInvocation.proceed(AbstractComponentMethodInvocation.java:71)
> # org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
> # org.apache.tapestry5.internal.transform.LogWorker$1.advise(LogWorker.java:54)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-832) Hidden input field fails with coercion
problem on empty value (patch incl)
Posted by "Sebastian Hennebrueder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Hennebrueder updated TAP5-832:
----------------------------------------
Attachment: Hidden.patch
patch to 5.2 trunk
> Hidden input field fails with coercion problem on empty value (patch incl)
> --------------------------------------------------------------------------
>
> Key: TAP5-832
> URL: https://issues.apache.org/jira/browse/TAP5-832
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0.0, 5.1.0.5
> Reporter: Sebastian Hennebrueder
> Attachments: Hidden.patch
>
>
> If a hidden field has a blanc input "" , it fails with the following stackstrace (my Hidden component is just a copy of the orginal of 5.1.0.5)
> The reason is that there is no nullfieldstrategie assigned to a hidden field as opposed to text fields. The attached patch adds such a strategie.
> # org.apache.tapestry5.internal.bindings.PropBinding.set(PropBinding.java:71)
> # org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl$1.write(InternalComponentResourcesImpl.java:540)
> # de.laliluna.bibabook.components.Hidden._$update_parameter_value(Hidden.java)
> # de.laliluna.bibabook.components.Hidden.processSubmission(Hidden.java:136)
> # de.laliluna.bibabook.components.Hidden.access$000(Hidden.java:37)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:94)
> # de.laliluna.bibabook.components.Hidden$ProcessSubmission.execute(Hidden.java:86)
> # org.apache.tapestry5.corelib.components.Form.executeStoredActions(Form.java:480)
> # org.apache.tapestry5.corelib.components.Form._$advised$onAction(Form.java:378)
> # org.apache.tapestry5.corelib.components.Form$onAction$invocation_1237b3fe6bd.invokeAdvisedMethod(Form$onAction$invocation_1237b3fe6bd.java)
> # org.apache.tapestry5.internal.services.AbstractComponentMethodInvocation.proceed(AbstractComponentMethodInvocation.java:71)
> # org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
> # org.apache.tapestry5.internal.transform.LogWorker$1.advise(LogWorker.java:54)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.