[GitHub] [hudi] yabola commented on a diff in pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree

[GitBox <gi...@apache.org>]

yabola commented on code in PR #5978:
URL: https://github.com/apache/hudi/pull/5978#discussion_r1005912907


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/IntervalTreeBasedGlobalIndexFileFilter.java:
##########
@@ -51,10 +50,6 @@ class IntervalTreeBasedGlobalIndexFileFilter implements IndexFileFilter {
       allIndexFiles.add(file);
     }));
 
-    // Note that the interval tree implementation doesn't have auto-balancing to ensure logN search time.
-    // So, we are shuffling the input here hoping the tree will not have any skewness. If not, the tree could be skewed
-    // which could result in N search time instead of NlogN.
-    Collections.shuffle(allIndexFiles);

Review Comment:
   Sorry, actually I don't have benchmark on it. I think red-black tree is a general optimization strategy like hashmap



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org