You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@thrift.apache.org by Mos Yud <mo...@gmail.com> on 2017/06/26 13:37:01 UTC

testing new patches

Hi,

At GitHub i see that for many commits there are some failure in tests.
1. In order to merge a patch, should the merged package pass all tests?
2. On what OSs the new package is tested on? (does it include windows XP)

Thx.
Moshe.

Re: testing new patches

Posted by Jens Geyer <je...@hotmail.com>.
There are two kinds of builds. Travis and AppVeyor. The Travis builds are 
all using Ubuntu, IIRC.




-----Ursprüngliche Nachricht----- 
From: Mos Yud
Sent: Tuesday, June 27, 2017 6:13 AM
To: user@thrift.apache.org
Subject: Re: testing new patches

After the problem solved, is it targeted to be tested also on Mac and Linux?

Thx,
Moshe.

On Tue, Jun 27, 2017 at 12:37 AM, Jens Geyer <je...@hotmail.com> wrote:

> Hi Mos,
>
> currently there are some problems with some of the Travis pre-commmit
> builds, but we're (in particular Eric) are about to resolve that.
>
> > 1. In order to merge a patch, should the merged package pass all tests?
>
> That would be nice. Yes, absolutely.
>
> > 2. On what OSs the new package is tested on? (does it include windows 
> > XP)
>
> You just used the terms "new" and "Windows XP" in one sentence. ;-) What 
> do
> you think?
>
> AFAIK the Appveyor builds run on Windows 10, but I'm not 100% sure about
> that. But it is very likely not WinXP.
>
> Have fun,
> JensG
>
>
>
> -----Ursprüngliche Nachricht-----
> From: Mos Yud
> Sent: Monday, June 26, 2017 3:37 PM
> To: user@thrift.apache.org
> Subject: testing new patches
>
> Hi,
>
> At GitHub i see that for many commits there are some failure in tests.
> 1. In order to merge a patch, should the merged package pass all tests?
> 2. On what OSs the new package is tested on? (does it include windows XP)
>
> Thx.
> Moshe.
>
> 


Re: testing new patches

Posted by Mos Yud <mo...@gmail.com>.
After the problem solved, is it targeted to be tested also on Mac and Linux?

Thx,
Moshe.

On Tue, Jun 27, 2017 at 12:37 AM, Jens Geyer <je...@hotmail.com> wrote:

> Hi Mos,
>
> currently there are some problems with some of the Travis pre-commmit
> builds, but we're (in particular Eric) are about to resolve that.
>
> > 1. In order to merge a patch, should the merged package pass all tests?
>
> That would be nice. Yes, absolutely.
>
> > 2. On what OSs the new package is tested on? (does it include windows XP)
>
> You just used the terms "new" and "Windows XP" in one sentence. ;-) What do
> you think?
>
> AFAIK the Appveyor builds run on Windows 10, but I'm not 100% sure about
> that. But it is very likely not WinXP.
>
> Have fun,
> JensG
>
>
>
> -----Ursprüngliche Nachricht-----
> From: Mos Yud
> Sent: Monday, June 26, 2017 3:37 PM
> To: user@thrift.apache.org
> Subject: testing new patches
>
> Hi,
>
> At GitHub i see that for many commits there are some failure in tests.
> 1. In order to merge a patch, should the merged package pass all tests?
> 2. On what OSs the new package is tested on? (does it include windows XP)
>
> Thx.
> Moshe.
>
>

Re: testing new patches

Posted by Jens Geyer <je...@hotmail.com>.
Hi Mos,

currently there are some problems with some of the Travis pre-commmit 
builds, but we're (in particular Eric) are about to resolve that.

> 1. In order to merge a patch, should the merged package pass all tests?

That would be nice. Yes, absolutely.

> 2. On what OSs the new package is tested on? (does it include windows XP)

You just used the terms "new" and "Windows XP" in one sentence. ;-) What do 
you think?

AFAIK the Appveyor builds run on Windows 10, but I'm not 100% sure about 
that. But it is very likely not WinXP.

Have fun,
JensG



-----Ursprüngliche Nachricht----- 
From: Mos Yud
Sent: Monday, June 26, 2017 3:37 PM
To: user@thrift.apache.org
Subject: testing new patches

Hi,

At GitHub i see that for many commits there are some failure in tests.
1. In order to merge a patch, should the merged package pass all tests?
2. On what OSs the new package is tested on? (does it include windows XP)

Thx.
Moshe.