[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2349: Added FlushIndexTask to flush documents at index thread level.

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #2349:
URL: https://github.com/apache/lucene-solr/pull/2349#discussion_r582790416



##########
File path: lucene/benchmark/conf/indexing-flush-by-RAM-multithreaded.alg
##########
@@ -53,7 +53,8 @@ log.queries=true
 
     { "Populate"
         CreateIndex
-        [{ "MAddDocs" AddDoc } : 5000] : 4
+        #[{ "MAddDocs" AddDoc } : 5000] : 4
+        [{ {{"MAddDocs" AddDoc } : 5000} FlushIndex }  ] : 20

Review comment:
       Maybe 1) remove the old (commented out) line entirely?  And 2), 20 threads seems a bit much for a "typical" box now?  Maybe go to 8 instead?
   
   Hmm, it would be nice if benchmarks made the local machine's CPU concurrency available (`Runtime.getRuntime().availableProcessors()`) so we could set this dynamically.  But that is for another day!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org