You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/17 18:42:45 UTC
[GitHub] [nifi] thenatog opened a new pull request #4911: NIFI-8329 - Updated dependencies that had no build/test failures when…
thenatog opened a new pull request #4911:
URL: https://github.com/apache/nifi/pull/4911
… updating.
NIFI-8329 - Not updating storm dependency in this change, as it is being removed in a separate ticket.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #4911: NIFI-8329 - Updated dependencies that had no build/test failures when…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #4911:
URL: https://github.com/apache/nifi/pull/4911#discussion_r597905559
##########
File path: nifi-nar-bundles/nifi-azure-bundle/pom.xml
##########
@@ -28,7 +28,7 @@
<properties>
<azure-storage.version>8.4.0</azure-storage.version>
<azure.core.version>1.6.0</azure.core.version>
- <jackson.version>2.10.3</jackson.version>
+ <jackson.version>2.12.2</jackson.version>
Review comment:
Thanks for confirming and making the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on a change in pull request #4911: NIFI-8329 - Updated dependencies that had no build/test failures when…
Posted by GitBox <gi...@apache.org>.
thenatog commented on a change in pull request #4911:
URL: https://github.com/apache/nifi/pull/4911#discussion_r597903371
##########
File path: nifi-nar-bundles/nifi-azure-bundle/pom.xml
##########
@@ -28,7 +28,7 @@
<properties>
<azure-storage.version>8.4.0</azure-storage.version>
<azure.core.version>1.6.0</azure.core.version>
- <jackson.version>2.10.3</jackson.version>
+ <jackson.version>2.12.2</jackson.version>
Review comment:
I thought I had issues with the property being picked up from this module, but I tested it again and it seems fine. Removed this with a new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #4911: NIFI-8329 - Updated dependencies that had no build/test failures when…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #4911:
URL: https://github.com/apache/nifi/pull/4911#discussion_r597787816
##########
File path: nifi-nar-bundles/nifi-azure-bundle/pom.xml
##########
@@ -28,7 +28,7 @@
<properties>
<azure-storage.version>8.4.0</azure-storage.version>
<azure.core.version>1.6.0</azure.core.version>
- <jackson.version>2.10.3</jackson.version>
+ <jackson.version>2.12.2</jackson.version>
Review comment:
Is there a reason for retaining this property in the `nifi-azure-bundle` or could it be removed so that the bundle relies on the property value of the root Maven configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4911: NIFI-8329 - Updated dependencies that had no build/test failures when…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4911:
URL: https://github.com/apache/nifi/pull/4911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org