You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:40:52 UTC

[GitHub] [shardingsphere] huanghao495430759 opened a new pull request #9787: Fix#9510. support rewrite SQL correctly when using sharding and encrypt together.

huanghao495430759 opened a new pull request #9787:
URL: https://github.com/apache/shardingsphere/pull/9787


   Fixes issue#9510.
   
   -refactor SubstitutableColumnNameToken to SubstitutableColumnsToken,support rewrite SQL correctly when using sharding and encrypt together.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] huanghao495430759 closed pull request #9787: Fix#9510. support rewrite SQL correctly when using sharding and encrypt together.

Posted by GitBox <gi...@apache.org>.
huanghao495430759 closed pull request #9787:
URL: https://github.com/apache/shardingsphere/pull/9787


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #9787: Fix#9510. support rewrite SQL correctly when using sharding and encrypt together.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9787:
URL: https://github.com/apache/shardingsphere/pull/9787#issuecomment-805736306


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=h1) Report
   > Merging [#9787](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=desc) (e2b3943) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a0163494bec0f684f14e9c3964228c7b4d690a4d?el=desc) (a016349) will **increase** coverage by `0.16%`.
   > The diff coverage is `55.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9787/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9787      +/-   ##
   ============================================
   + Coverage     67.60%   67.77%   +0.16%     
   + Complexity      680      677       -3     
   ============================================
     Files          1667     1669       +2     
     Lines         27844    27891      +47     
     Branches       4925     4943      +18     
   ============================================
   + Hits          18824    18903      +79     
   + Misses         7641     7598      -43     
   - Partials       1379     1390      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...te/sql/token/pojo/generic/SubstitutableColumn.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1N1YnN0aXR1dGFibGVDb2x1bW4uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...mmon/segment/dml/item/ColumnProjectionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZG1sL2l0ZW0vQ29sdW1uUHJvamVjdGlvblNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/infra/rewrite/sql/impl/AbstractSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvaW1wbC9BYnN0cmFjdFNRTEJ1aWxkZXIuamF2YQ==) | `46.87% <20.00%> (-39.80%)` | `0.00 <0.00> (ø)` | |
   | [.../token/pojo/generic/SubstitutableColumnsToken.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1N1YnN0aXR1dGFibGVDb2x1bW5zVG9rZW4uamF2YQ==) | `31.57% <31.57%> (ø)` | `0.00 <0.00> (?)` | |
   | [...generator/impl/InsertCipherNameTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9JbnNlcnRDaXBoZXJOYW1lVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `94.73% <87.50%> (-5.27%)` | `1.00 <1.00> (+1.00)` | :arrow_down: |
   | [...enerator/impl/EncryptAlterTableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0QWx0ZXJUYWJsZVRva2VuR2VuZXJhdG9yLmphdmE=) | `98.78% <100.00%> (+1.21%)` | `0.00 <0.00> (ø)` | |
   | [...nerator/impl/EncryptCreateTableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0Q3JlYXRlVGFibGVUb2tlbkdlbmVyYXRvci5qYXZh) | `96.29% <100.00%> (+0.46%)` | `0.00 <0.00> (ø)` | |
   | [...tor/impl/EncryptPredicateColumnTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0UHJlZGljYXRlQ29sdW1uVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `89.47% <100.00%> (+1.59%)` | `1.00 <0.00> (ø)` | |
   | [...enerator/impl/EncryptProjectionTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0UHJvamVjdGlvblRva2VuR2VuZXJhdG9yLmphdmE=) | `81.25% <100.00%> (+4.65%)` | `1.00 <0.00> (ø)` | |
   | [...nfra/metadata/resource/ShardingSphereResource.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZXNvdXJjZS9TaGFyZGluZ1NwaGVyZVJlc291cmNlLmphdmE=) | `66.66% <0.00%> (-13.34%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [36 more](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=footer). Last update [a016349...e2b3943](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #9787: Fix#9510. support rewrite SQL correctly when using sharding and encrypt together.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9787:
URL: https://github.com/apache/shardingsphere/pull/9787#issuecomment-805736306


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=h1) Report
   > Merging [#9787](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=desc) (86413b1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a0163494bec0f684f14e9c3964228c7b4d690a4d?el=desc) (a016349) will **increase** coverage by `0.19%`.
   > The diff coverage is `66.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9787/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9787      +/-   ##
   ============================================
   + Coverage     67.60%   67.80%   +0.19%     
   + Complexity      680      678       -2     
   ============================================
     Files          1667     1673       +6     
     Lines         27844    28157     +313     
     Branches       4925     5003      +78     
   ============================================
   + Hits          18824    19091     +267     
   - Misses         7641     7642       +1     
   - Partials       1379     1424      +45     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...te/sql/token/pojo/generic/SubstitutableColumn.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1N1YnN0aXR1dGFibGVDb2x1bW4uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...mmon/segment/dml/item/ColumnProjectionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZG1sL2l0ZW0vQ29sdW1uUHJvamVjdGlvblNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/infra/rewrite/sql/impl/AbstractSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvaW1wbC9BYnN0cmFjdFNRTEJ1aWxkZXIuamF2YQ==) | `46.87% <20.00%> (-39.80%)` | `0.00 <0.00> (ø)` | |
   | [.../token/pojo/generic/SubstitutableColumnsToken.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zaGFyZGluZ3NwaGVyZS1pbmZyYS1yZXdyaXRlLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL1N1YnN0aXR1dGFibGVDb2x1bW5zVG9rZW4uamF2YQ==) | `60.52% <60.52%> (ø)` | `0.00 <0.00> (?)` | |
   | [...generator/impl/InsertCipherNameTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9JbnNlcnRDaXBoZXJOYW1lVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `94.73% <87.50%> (-5.27%)` | `1.00 <1.00> (+1.00)` | :arrow_down: |
   | [...enerator/impl/EncryptAlterTableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0QWx0ZXJUYWJsZVRva2VuR2VuZXJhdG9yLmphdmE=) | `98.78% <100.00%> (+1.21%)` | `0.00 <0.00> (ø)` | |
   | [...nerator/impl/EncryptCreateTableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0Q3JlYXRlVGFibGVUb2tlbkdlbmVyYXRvci5qYXZh) | `96.29% <100.00%> (+0.46%)` | `0.00 <0.00> (ø)` | |
   | [...tor/impl/EncryptPredicateColumnTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0UHJlZGljYXRlQ29sdW1uVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `89.47% <100.00%> (+1.59%)` | `1.00 <0.00> (ø)` | |
   | [...enerator/impl/EncryptProjectionTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0UHJvamVjdGlvblRva2VuR2VuZXJhdG9yLmphdmE=) | `81.25% <100.00%> (+4.65%)` | `1.00 <0.00> (ø)` | |
   | [...rmer/advice/ComposeInstanceMethodAroundAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9ieXRlYnVkZHkvdHJhbnNmb3JtZXIvYWR2aWNlL0NvbXBvc2VJbnN0YW5jZU1ldGhvZEFyb3VuZEFkdmljZS5qYXZh) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [75 more](https://codecov.io/gh/apache/shardingsphere/pull/9787/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=footer). Last update [a016349...86413b1](https://codecov.io/gh/apache/shardingsphere/pull/9787?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #9787: Fix#9510. support rewrite SQL correctly when using sharding and encrypt together.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9787:
URL: https://github.com/apache/shardingsphere/pull/9787#issuecomment-810040814


   Hi thanks @huanghao495430759 ,
   
   @terrymanu Could you have a look at this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org