You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/30 03:56:00 UTC

[GitHub] [arrow] kou opened a new pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

kou opened a new pull request #7067:
URL: https://github.com/apache/arrow/pull/7067


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621682935


   @github-actions crossbow submit centos-*-amd64


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621683602


   Revision: 1e7228ec58c829ba1ad31b27d2d2920f2eb2d8e8
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-179](https://github.com/ursa-labs/crossbow/branches/all?query=actions-179)
   
   |Task|Status|
   |----|------|
   |centos-6-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-179-github-centos-6-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-179-github-centos-6-amd64)|
   |centos-7-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-179-github-centos-7-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-179-github-centos-7-amd64)|
   |centos-8-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-179-github-centos-8-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-179-github-centos-8-amd64)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621597763


   @github-actions crossbow submit centos-6-amd64 centos-7-amd64 ubuntu-xenial-amd64


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621659219






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621660053


   Revision: ed66e887a0b871bf55580894d50ab4ef606f3e2f
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-178](https://github.com/ursa-labs/crossbow/branches/all?query=actions-178)
   
   |Task|Status|
   |----|------|
   |centos-6-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-178-github-centos-6-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-178-github-centos-6-amd64)|
   |centos-7-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-178-github-centos-7-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-178-github-centos-7-amd64)|
   |ubuntu-xenial-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-178-github-ubuntu-xenial-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-178-github-ubuntu-xenial-amd64)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] emkornfield commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621634453


   Is centos-6-amd64 failure OK?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#discussion_r418272894



##########
File path: cpp/cmake_modules/FindgflagsAlt.cmake
##########
@@ -15,6 +15,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# TODO: Support version detection.

Review comment:
       Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs commented on a change in pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#discussion_r418109900



##########
File path: cpp/cmake_modules/FindgflagsAlt.cmake
##########
@@ -15,6 +15,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# TODO: Support version detection.

Review comment:
       Created a follow-up ticket https://issues.apache.org/jira/browse/ARROW-8653




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] emkornfield commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621634239


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621598056


   Revision: c7cfc529009108515865cbdbe9541e3a4c435290
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-177](https://github.com/ursa-labs/crossbow/branches/all?query=actions-177)
   
   |Task|Status|
   |----|------|
   |centos-6-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-177-github-centos-6-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-177-github-centos-6-amd64)|
   |centos-7-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-177-github-centos-7-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-177-github-centos-7-amd64)|
   |ubuntu-xenial-amd64|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-177-github-ubuntu-xenial-amd64)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-177-github-ubuntu-xenial-amd64)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7067: ARROW-8639: [C++][Plasma] Require gflags

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7067:
URL: https://github.com/apache/arrow/pull/7067#issuecomment-621599060


   https://issues.apache.org/jira/browse/ARROW-8639


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org