You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2024/03/01 09:54:41 UTC
[PR] [fix](profile)Fix load profile print by default [doris]
xinyiZzz opened a new pull request, #31677:
URL: https://github.com/apache/doris/pull/31677
## Proposed changes
only enable_profile is true, print profile.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972917309
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972870875
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972907676
TeamCity be ut coverage result:
Function Coverage: 35.64% (8549/23989)
Line Coverage: 27.45% (69395/252821)
Region Coverage: 26.62% (36006/135282)
Branch Coverage: 23.43% (18398/78514)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9b655d0f45a23ac2019f63a338f821c5b8bd17c4_9b655d0f45a23ac2019f63a338f821c5b8bd17c4/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972870965
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972887651
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972910384
<details>
<summary>TPC-H: <b>Total hot run time: 32341 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9b655d0f45a23ac2019f63a338f821c5b8bd17c4, data reload: false
------ Round 1 ----------------------------------
q1 18860 4498 4693 4498
q2 2244 218 231 218
q3 11307 1130 1091 1091
q4 5003 1156 1144 1144
q5 7978 2041 2047 2041
q6 156 114 112 112
q7 1216 1081 1085 1081
q8 9822 1088 1132 1088
q9 6288 5023 4885 4885
q10 7904 1960 2024 1960
q11 549 327 325 325
q12 806 403 401 401
q13 18075 2913 2905 2905
q14 332 309 306 306
q15 395 351 347 347
q16 539 494 488 488
q17 795 333 322 322
q18 5575 4929 4967 4929
q19 1189 437 426 426
q20 610 450 438 438
q21 5858 2881 2858 2858
q22 534 479 478 478
Total cold run time: 106035 ms
Total hot run time: 32341 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4719 4696 4703 4696
q2 325 236 212 212
q3 2215 1788 1874 1788
q4 1624 1274 1323 1274
q5 3306 3058 2971 2971
q6 152 104 107 104
q7 1883 1855 1859 1855
q8 1788 1691 1682 1682
q9 5344 5215 5185 5185
q10 2699 2314 2219 2219
q11 487 426 414 414
q12 788 642 652 642
q13 3156 2647 2604 2604
q14 292 288 287 287
q15 359 347 334 334
q16 519 505 489 489
q17 1138 802 830 802
q18 5848 5537 5306 5306
q19 1134 689 645 645
q20 1618 1432 1362 1362
q21 4790 4494 4271 4271
q22 677 611 625 611
Total cold run time: 44861 ms
Total hot run time: 39753 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972937804
<details>
<summary>ClickBench: <b>Total hot run time: 26.76 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9b655d0f45a23ac2019f63a338f821c5b8bd17c4, data reload: false
query1 0.06 0.04 0.03
query2 0.12 0.04 0.04
query3 0.28 0.06 0.07
query4 1.60 0.09 0.09
query5 0.50 0.49 0.48
query6 1.49 0.96 0.99
query7 0.04 0.02 0.02
query8 0.07 0.04 0.05
query9 0.69 0.65 0.63
query10 0.68 0.69 0.69
query11 0.23 0.15 0.16
query12 0.19 0.16 0.15
query13 0.50 0.47 0.48
query14 0.73 0.71 0.74
query15 0.90 0.87 0.91
query16 0.41 0.40 0.39
query17 1.17 1.19 1.29
query18 0.35 0.33 0.30
query19 2.14 2.06 2.04
query20 0.03 0.02 0.03
query21 15.39 0.95 0.87
query22 0.58 0.57 0.59
query23 13.66 0.63 0.65
query24 0.80 0.18 0.19
query25 0.04 0.05 0.05
query26 0.21 0.20 0.20
query27 0.05 0.07 0.04
query28 1.62 0.76 0.72
query29 12.89 4.64 4.60
query30 0.85 0.83 0.82
query31 0.85 0.42 0.40
query32 3.24 0.41 0.40
query33 2.39 2.23 2.35
query34 2.19 2.18 2.21
query35 2.20 2.19 2.17
query36 1.00 0.97 0.97
query37 0.08 0.06 0.06
query38 0.06 0.05 0.04
query39 0.04 0.03 0.03
query40 0.19 0.20 0.18
query41 0.10 0.03 0.03
query42 0.05 0.02 0.03
query43 0.04 0.04 0.04
Total cold run time: 70.7 s
Total hot run time: 26.76 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972917228
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31677:
URL: https://github.com/apache/doris/pull/31677#issuecomment-1972930538
<details>
<summary>TPC-DS: <b>Total hot run time: 188359 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9b655d0f45a23ac2019f63a338f821c5b8bd17c4, data reload: false
query1 1027 394 404 394
query2 7876 2395 2383 2383
query3 6738 303 306 303
query4 24598 22968 23439 22968
query5 5189 706 754 706
query6 408 283 285 283
query7 4682 429 436 429
query8 311 247 233 233
query9 8642 3456 3387 3387
query10 563 350 354 350
query11 18003 18929 19406 18929
query12 350 245 203 203
query13 1756 671 689 671
query14 11442 7427 7292 7292
query15 316 250 242 242
query16 8350 438 410 410
query17 2029 702 678 678
query18 2185 414 402 402
query19 276 242 261 242
query20 149 148 143 143
query21 242 170 176 170
query22 5422 5012 4958 4958
query23 24220 23875 24375 23875
query24 6826 2106 2068 2068
query25 598 514 492 492
query26 787 237 236 236
query27 2302 490 487 487
query28 3299 2849 2836 2836
query29 961 763 767 763
query30 313 192 196 192
query31 1379 852 811 811
query32 135 102 90 90
query33 655 375 394 375
query34 863 673 699 673
query35 984 905 881 881
query36 1227 1201 1170 1170
query37 137 111 107 107
query38 3199 3005 2976 2976
query39 1145 1079 1099 1079
query40 258 170 167 167
query41 90 83 89 83
query42 155 145 158 145
query43 614 587 606 587
query44 1261 1069 1081 1069
query45 220 217 214 214
query46 898 789 793 789
query47 1710 1696 1657 1657
query48 605 535 545 535
query49 727 474 479 474
query50 668 552 560 552
query51 10994 11226 10797 10797
query52 153 143 143 143
query53 338 335 332 332
query54 380 381 363 363
query55 177 134 131 131
query56 344 343 335 335
query57 1094 1033 1016 1016
query58 354 335 339 335
query59 3550 3457 3354 3354
query60 386 391 399 391
query61 194 166 165 165
query62 542 438 414 414
query63 320 323 327 323
query64 4265 1866 1838 1838
query65 2402 2317 2329 2317
query66 901 404 382 382
query67 15266 15655 15021 15021
query68 2176 732 702 702
query69 660 578 556 556
query70 1592 1615 1581 1581
query71 469 423 422 422
query72 2843 2325 2296 2296
query73 681 482 485 482
query74 6961 7004 6906 6906
query75 3164 2712 2770 2712
query76 2072 670 660 660
query77 499 413 411 411
query78 6949 6381 6367 6367
query79 1099 800 768 768
query80 658 596 579 579
query81 468 265 259 259
query82 186 134 138 134
query83 249 239 236 236
query84 278 137 134 134
query85 861 547 531 531
query86 446 429 423 423
query87 3431 3144 3167 3144
query88 3700 3471 3467 3467
query89 467 411 421 411
query90 999 226 230 226
query91 202 202 206 202
query92 87 84 83 83
query93 1030 742 695 695
query94 506 275 279 275
query95 574 524 526 524
query96 623 384 388 384
query97 3057 2967 2936 2936
query98 315 332 313 313
query99 852 731 724 724
Total cold run time: 256604 ms
Total hot run time: 188359 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile)Fix load profile print by default [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz merged PR #31677:
URL: https://github.com/apache/doris/pull/31677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org