[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15980: [Enhencement](Push Handle) use VParquetScanner in PushHandle

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15980:
URL: https://github.com/apache/doris/pull/15980#discussion_r1071077977


##########
be/src/olap/push_handler.h:
##########
@@ -178,31 +178,27 @@ class LzoBinaryReader : public IBinaryReader {
 
 class PushBrokerReader {
 public:
-    PushBrokerReader() : _ready(false), _eof(false), _fill_tuple(false) {}
+    PushBrokerReader() : _ready(false), _eof(false) {}
     ~PushBrokerReader() = default;
 
     Status init(const Schema* schema, const TBrokerScanRange& t_scan_range,
                 const TDescriptorTable& t_desc_tbl);
-    Status next(ContiguousRow* row);
+    Status next(vectorized::Block* block);
     void print_profile();
 
     Status close() {
         _ready = false;
         return Status::OK();
     }
     bool eof() const { return _eof; }
-    bool is_fill_tuple() const { return _fill_tuple; }
     MemPool* mem_pool() { return _mem_pool.get(); }
 
 private:
     Status fill_field_row(RowCursorCell* dst, const char* src, bool src_null, MemPool* mem_pool,
                           FieldType type);
     bool _ready;
     bool _eof;
-    bool _fill_tuple;
     TupleDescriptor* _tuple_desc;

Review Comment:
   warning: private field '_tuple_desc' is not used [clang-diagnostic-unused-private-field]
   ```cpp
       TupleDescriptor* _tuple_desc;
                        ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org