You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/11 04:44:04 UTC
[jira] [Commented] (BEAM-2246) JmsIO should use CLIENT_ACK instead
of AUTO_ACK
[ https://issues.apache.org/jira/browse/BEAM-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005880#comment-16005880 ]
ASF GitHub Bot commented on BEAM-2246:
--------------------------------------
GitHub user jbonofre opened a pull request:
https://github.com/apache/beam/pull/3073
[BEAM-2246] Use CLIENT_ACK instead of AUTO_ACK in JmsIO
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`.
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/beam BEAM-2246-JMS-SESSION
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3073
----
commit de00c58808902d5d4593fba41f637884df67c90b
Author: Jean-Baptiste Onofré <jb...@apache.org>
Date: 2017-05-10T05:39:56Z
[BEAM-2246] Use CLIENT_ACK instead of AUTO_ACK in JmsIO
----
> JmsIO should use CLIENT_ACK instead of AUTO_ACK
> -----------------------------------------------
>
> Key: BEAM-2246
> URL: https://issues.apache.org/jira/browse/BEAM-2246
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Affects Versions: 0.6.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
>
> As {{JmsIO}} manages the messages acknowledgement in its checkpoint, it should not use {{AUTO_ACKNOWLEDGE}} but {{CLIENT_ACKNOWLEDGE}}.
> With {{AUTO_ACK}}, the ack is sent to the JMS broker as soon as the message is consumed. Basically, it means that the checkpoint is useless as, if something goes wrong in the pipeline, the messages is already consumed from the broker (so no way to redeliver the message).
> Instead, {{JmsIO}} should use {{CLIENT_ACK}} and explicitly send the ack (commit) in the checkpoint (the code is already in place).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)