You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2022/05/25 07:15:50 UTC

[shardingsphere] branch master updated: Unit test sharding sphere rule meta data (#17913)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 279640ba4f0 Unit test sharding sphere rule meta data (#17913)
279640ba4f0 is described below

commit 279640ba4f0b62c11e958150b0ed6a640fcfb90a
Author: Panagiotis Parthenis <pp...@gmail.com>
AuthorDate: Wed May 25 10:15:42 2022 +0300

    Unit test sharding sphere rule meta data (#17913)
    
    * add unit test for ShardingSphereRuleMetaData
    
    * add unit test for ShardingSphereRuleMetaData, fix checkstyle
---
 ...st.java => ShardingSphereRuleConfiguration.java} | 21 ++-------------------
 .../rule/ShardingSphereRuleMetaDataTest.java        | 14 +++++++++++++-
 2 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleConfiguration.java
similarity index 54%
copy from shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java
copy to shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleConfiguration.java
index e4410b93879..32d40efbcc5 100644
--- a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java
+++ b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleConfiguration.java
@@ -17,25 +17,8 @@
 
 package org.apache.shardingsphere.infra.metadata.rule;
 
-import org.junit.Test;
+import org.apache.shardingsphere.infra.config.scope.SchemaRuleConfiguration;
 
-import java.util.Collections;
+public class ShardingSphereRuleConfiguration implements SchemaRuleConfiguration {
 
-import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.assertTrue;
-
-public final class ShardingSphereRuleMetaDataTest {
-    
-    private final ShardingSphereRuleMetaData ruleMetaData = new ShardingSphereRuleMetaData(Collections.emptyList(), Collections.singleton(new ShardingSphereRuleFixture()));
-    
-    @Test
-    public void assertFindRules() {
-        assertThat(ruleMetaData.findRules(ShardingSphereRuleFixture.class).size(), is(1));
-    }
-    
-    @Test
-    public void assertFindSingleRule() {
-        assertTrue(ruleMetaData.findSingleRule(ShardingSphereRuleFixture.class).isPresent());
-    }
 }
diff --git a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java
index e4410b93879..9d8fca709c4 100644
--- a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java
+++ b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java
@@ -27,7 +27,9 @@ import static org.junit.Assert.assertTrue;
 
 public final class ShardingSphereRuleMetaDataTest {
     
-    private final ShardingSphereRuleMetaData ruleMetaData = new ShardingSphereRuleMetaData(Collections.emptyList(), Collections.singleton(new ShardingSphereRuleFixture()));
+    private final ShardingSphereRuleMetaData ruleMetaData = new ShardingSphereRuleMetaData(
+            Collections.singleton(new ShardingSphereRuleConfiguration()),
+            Collections.singleton(new ShardingSphereRuleFixture()));
     
     @Test
     public void assertFindRules() {
@@ -38,4 +40,14 @@ public final class ShardingSphereRuleMetaDataTest {
     public void assertFindSingleRule() {
         assertTrue(ruleMetaData.findSingleRule(ShardingSphereRuleFixture.class).isPresent());
     }
+    
+    @Test
+    public void assertFindRuleConfigurations() {
+        assertThat(ruleMetaData.findRuleConfigurations(ShardingSphereRuleConfiguration.class).size(), is(1));
+    }
+
+    @Test
+    public void assertFindSingleRuleConfiguration() {
+        assertTrue(ruleMetaData.findSingleRuleConfiguration(ShardingSphereRuleConfiguration.class).isPresent());
+    }
 }