You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "XiangpengHao (via GitHub)" <gi...@apache.org> on 2025/01/17 03:36:23 UTC
[PR] Make `ParquetField` public [arrow-rs]
XiangpengHao opened a new pull request, #6991:
URL: https://github.com/apache/arrow-rs/pull/6991
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
`ParquetField` (and its friends) are foundation types in the crate, without this being public, many of the functions can't be called, e.g., `build_array_reader`. If this is public, downstream users can easily hooking their own parquet reading logic while still reusing much of the existing code.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make `ParquetField` public [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6991:
URL: https://github.com/apache/arrow-rs/pull/6991#issuecomment-2599129976
ParquetField currently has public members, we might want to change this. As it stands even adding a field would be a breaking API change.
Taking a step back, why do you want this public, what public APIs make use of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make `ParquetField` public [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6991:
URL: https://github.com/apache/arrow-rs/pull/6991#issuecomment-2599260004
> build_array_reader is public under experimental feature.
Perhaps we could make this public under the same experimental feature gate? I'm being cautious as we've been stung in the past by exposing too much of this crates' internals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make `ParquetField` public [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6991:
URL: https://github.com/apache/arrow-rs/pull/6991#issuecomment-2599277344
Marking as draft -- please mark it as ready to review when it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make `ParquetField` public [arrow-rs]
Posted by "XiangpengHao (via GitHub)" <gi...@apache.org>.
XiangpengHao commented on PR #6991:
URL: https://github.com/apache/arrow-rs/pull/6991#issuecomment-2599262643
> Perhaps we could make this public under the same experimental feature gate?
Sounds great! Will do soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make `ParquetField` public [arrow-rs]
Posted by "XiangpengHao (via GitHub)" <gi...@apache.org>.
XiangpengHao commented on PR #6991:
URL: https://github.com/apache/arrow-rs/pull/6991#issuecomment-2607521478
I'll need to think more carefully on what should be public, let's close this until I have a better understanding of how to proceed. Thank you for the review! @alamb @etseidl @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make `ParquetField` public [arrow-rs]
Posted by "XiangpengHao (via GitHub)" <gi...@apache.org>.
XiangpengHao closed pull request #6991: Make `ParquetField` public
URL: https://github.com/apache/arrow-rs/pull/6991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make `ParquetField` public [arrow-rs]
Posted by "XiangpengHao (via GitHub)" <gi...@apache.org>.
XiangpengHao commented on PR #6991:
URL: https://github.com/apache/arrow-rs/pull/6991#issuecomment-2599243937
> build_array_reader is not public, or at least shouldn't be...
`build_array_reader` is public under `experimental` feature.
> why do you want this public
The current `ParquetRecordBatchReader` is a black box, my use case would want finer control over how data is read, e.g., decode timing.
> As it stands even adding a field would be a breaking API change once made public
That's a good point, but this specific type has not changed for 3 years and probably won't change for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org