You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/17 14:14:03 UTC
[GitHub] [inlong] yunqingmoswu opened a new pull request, #5588: [INLONG-5576][Sort] Add redis extract node and support temporal join
yunqingmoswu opened a new pull request, #5588:
URL: https://github.com/apache/inlong/pull/5588
### Prepare a Pull Request
*(Change the title refer to the following example)*
Title: [INLONG-5576][Sort] Add redis extract node and support temporal join
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
Fixes #5576
### Motivation
Add redis extract node and support temporal join for FlinkSqlParser.
### Modifications
1.Add RedisExtractNode
2.Support temporal join(left and inner join) for FlinkSqlParser
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [x] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5588: [INLONG-5576][Sort] Add Redis extract node and support temporal join
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5588:
URL: https://github.com/apache/inlong/pull/5588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5588: [INLONG-5576][Sort] Add Redis extract node and support temporal join
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5588:
URL: https://github.com/apache/inlong/pull/5588#discussion_r948619141
##########
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/RedisTemporalJoinSqlParseTest.java:
##########
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
Review Comment:
The license header was not the same as others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org