You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/24 12:09:09 UTC
[GitHub] [airflow] mnojek opened a new pull request #17809: Fix typos in documentation and command example in comment in bug_report template
mnojek opened a new pull request #17809:
URL: https://github.com/apache/airflow/pull/17809
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Related: #17727
Just some small fixes of obvious typos found when reading documentation (some found with help of LanguageTool). Also, fixed the broken example of command in the comment inside bug_report.md template for GitHub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#discussion_r694797631
##########
File path: .github/ISSUE_TEMPLATE/bug_report.md
##########
@@ -19,7 +19,7 @@ Please complete the next sections or the issue will be closed.
**OS**:
-<!-- MANDATORY! You can get it via `cat /etc/oss-release` for example -->
+<!-- MANDATORY! You can get it via `cat /etc/os-release` for example -->
Review comment:
Hmm, I think I saw another PR on this a few days ago, but can’t find it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mnojek commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
mnojek commented on a change in pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#discussion_r694869948
##########
File path: BREEZE.rst
##########
@@ -718,13 +718,13 @@ The above will run mypy check for all files.
</a>
</div>
-If you want ever need to get a list of the files that will be checked (for troubleshooting when playing with the
-``--from-ref`` and ``--to-ref``
+If you will ever need to get a list of the files that will be checked (for troubleshooting when playing with the
+``--from-ref`` and ``--to-ref``) use these commands:
Review comment:
Yeah, I think it's better. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#issuecomment-905928116
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mnojek commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
mnojek commented on a change in pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#discussion_r694870693
##########
File path: .github/ISSUE_TEMPLATE/bug_report.md
##########
@@ -19,7 +19,7 @@ Please complete the next sections or the issue will be closed.
**OS**:
-<!-- MANDATORY! You can get it via `cat /etc/oss-release` for example -->
+<!-- MANDATORY! You can get it via `cat /etc/os-release` for example -->
Review comment:
Maybe you saw my comment inside #17727 about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#issuecomment-904581056
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17809:
URL: https://github.com/apache/airflow/pull/17809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#discussion_r694798570
##########
File path: BREEZE.rst
##########
@@ -718,13 +718,13 @@ The above will run mypy check for all files.
</a>
</div>
-If you want ever need to get a list of the files that will be checked (for troubleshooting when playing with the
-``--from-ref`` and ``--to-ref``
+If you will ever need to get a list of the files that will be checked (for troubleshooting when playing with the
+``--from-ref`` and ``--to-ref``) use these commands:
Review comment:
```suggestion
If you ever need to get a list of the files that will be checked (for troubleshooting when playing with
``--from-ref`` and ``--to-ref``), use these commands:
```
I think this is the correct grammar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mnojek commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
mnojek commented on a change in pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#discussion_r696084606
##########
File path: .github/ISSUE_TEMPLATE/bug_report.md
##########
@@ -19,7 +19,7 @@ Please complete the next sections or the issue will be closed.
**OS**:
-<!-- MANDATORY! You can get it via `cat /etc/oss-release` for example -->
+<!-- MANDATORY! You can get it via `cat /etc/os-release` for example -->
Review comment:
Can I resolve this thread, @uranusjr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#issuecomment-905928284
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #17809: Fix typos in documentation and command example in comment in bug_report template
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #17809:
URL: https://github.com/apache/airflow/pull/17809#discussion_r695302104
##########
File path: BREEZE.rst
##########
@@ -718,13 +718,13 @@ The above will run mypy check for all files.
</a>
</div>
-If you want ever need to get a list of the files that will be checked (for troubleshooting when playing with the
-``--from-ref`` and ``--to-ref``
+If you ever need to get a list of the files that will be checked (for troubleshooting when playing with
+``--from-ref`` and ``--to-ref``), use these commands:
Review comment:
```suggestion
If you ever need to get a list of the files that will be checked (for troubleshooting when playing with
``--from-ref`` and ``--to-ref``), use these commands:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org