[GitHub] [activemq-artemis] gemmellr commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core

[GitBox <gi...@apache.org>]

gemmellr commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521271924
 
 
   I think this is a reasonable enough thing to do in the circumstance. The properties that would be created are already fairly AMQP interop centric through their names, as the existing related ones already are, so the content being especially so when required doesnt seem particularly odd. Dropping them might work if another way was currently found to preserve them in flight for AMQP recipients, but would be a bit unexpected that some things transit while others silently dont.
   
   Rewiring the brokers large message support doesnt seem like a small thing to do, I wouldnt tie this comparatively small issue to that personally. Doing so still wouldnt address the cross-protocol aspect where this issue was actually hit and reported originally. 
   
   While complex types are usable in others areas such as the annotations section as seen here, AMQP does not permit complex application-properties, so extending Core for that would actually introduce [more?] scope for the same problem in reverse for Core to AMQP and the other protocols, so I dont think I would go there to resolve this either. Even if doing so, any user custom described types would probably still require something along these lines I think (or again, dropping).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services