You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/05 00:05:25 UTC

[GitHub] [gobblin] umustafi commented on a change in pull request #3297: [GOBBLIN-1458] Add endpoint to trigger a flow in GaaS

umustafi commented on a change in pull request #3297:
URL: https://github.com/apache/gobblin/pull/3297#discussion_r645910325



##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
##########
@@ -160,6 +160,8 @@ public void testCheckFlowExecutionId() throws Exception {
   @Test
   public void testPartialUpdate() throws Exception {
     FlowId flowId = new FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_3);
+    ServiceRequester testRequester = new ServiceRequester("testName", "USER_PRINCIPAL", "testFrom");

Review comment:
       nitpick but do we want to add these as constants if they are reused? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org