[GitHub] [iceberg] coolderli commented on a change in pull request #3990: Core: Use min sequence number on each partition to remove old delete files

[GitBox <gi...@apache.org>]

coolderli commented on a change in pull request #3990:
URL: https://github.com/apache/iceberg/pull/3990#discussion_r793363591



##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -86,7 +86,10 @@ public String partition() {
   private final Map<ManifestFile, Iterable<F>> filteredManifestToDeletedFiles =
       Maps.newConcurrentMap();
 
-  protected ManifestFilterManager(Map<Integer, PartitionSpec> specsById) {
+  // tracking the min sequence number of data files on each partition
+  private final Map<String, Long> minSequenceNumberByPartition = Maps.newHashMap();

Review comment:
       There I use the `String` as the key of the map because `StructLikeMap` only supports one partition spec. When we scan the data manifest files, there may be multi-different partition specs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org