You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2011/04/05 01:39:05 UTC
[jira] [Created] (WICKET-3594) Upload progress bar don't report max
size exception
Upload progress bar don't report max size exception
---------------------------------------------------
Key: WICKET-3594
URL: https://issues.apache.org/jira/browse/WICKET-3594
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.5-RC3, 1.4.17
Reporter: Pedro Santos
Assignee: Pedro Santos
Can be reproduced at http://wicketstuff.org/wicket/upload/single simple trying to upload a file higher than 100k
http://apache.markmail.org/search/?q=UploadProgressBar+Possible+Bug#query:UploadProgressBar%20Possible%20Bug+page:1+mid:ehfjyvugtncam5gr+state:results
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3594) Upload progress bar don't report
max size exception
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos resolved WICKET-3594.
----------------------------------
Resolution: Duplicate
duplicates WICKET-3525
Sure, thanks for pointing out Attila. The max size exception don't get reported because of the container behavior you described.
Anyway I think we can hide the progress bar and present the error message even if the file are still being uploaded by browser.
> Upload progress bar don't report max size exception
> ---------------------------------------------------
>
> Key: WICKET-3594
> URL: https://issues.apache.org/jira/browse/WICKET-3594
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.17, 1.5-RC3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
>
> Can be reproduced at http://wicketstuff.org/wicket/upload/single simple trying to upload a file higher than 100k
> http://apache.markmail.org/search/?q=UploadProgressBar+Possible+Bug#query:UploadProgressBar%20Possible%20Bug+page:1+mid:ehfjyvugtncam5gr+state:results
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3594) Upload progress bar don't report
max size exception
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032627#comment-13032627 ]
Attila Király commented on WICKET-3594:
---------------------------------------
Imho this issue is related to WICKET-3525. I asked about this in March on the tomcat user list and I got the info that in tomcat 7.0.11+ there is a new option to abort uploads [1]. However it couses network error in every browser. It could still be used with ajax uploads if you direct the file uplaod post target to an iframe but I do not know (did not try) if you can detect the iframe network error from javascript.
[1] http://old.nabble.com/How-to-prevent-abort-the-processing-of-the-multipart-request-body--td31141883.html
> Upload progress bar don't report max size exception
> ---------------------------------------------------
>
> Key: WICKET-3594
> URL: https://issues.apache.org/jira/browse/WICKET-3594
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.17, 1.5-RC3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
>
> Can be reproduced at http://wicketstuff.org/wicket/upload/single simple trying to upload a file higher than 100k
> http://apache.markmail.org/search/?q=UploadProgressBar+Possible+Bug#query:UploadProgressBar%20Possible%20Bug+page:1+mid:ehfjyvugtncam5gr+state:results
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3594) Upload progress bar don't report
max size exception
Posted by "John Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032570#comment-13032570 ]
John Owen commented on WICKET-3594:
-----------------------------------
See maxPostSize setting or http://tomcat.apache.org/tomcat-6.0-doc/api/org/apache/tomcat/util/http/fileupload/FileUploadBase.html for restricting file upload size.
> Upload progress bar don't report max size exception
> ---------------------------------------------------
>
> Key: WICKET-3594
> URL: https://issues.apache.org/jira/browse/WICKET-3594
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.17, 1.5-RC3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
>
> Can be reproduced at http://wicketstuff.org/wicket/upload/single simple trying to upload a file higher than 100k
> http://apache.markmail.org/search/?q=UploadProgressBar+Possible+Bug#query:UploadProgressBar%20Possible%20Bug+page:1+mid:ehfjyvugtncam5gr+state:results
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3594) Upload progress bar don't report
max size exception
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032674#comment-13032674 ]
Attila Király commented on WICKET-3594:
---------------------------------------
Pedro: yep that could be done. In addition wicket could not abort the upload but do the silent processing so the progress bar is still updated even when it is known that the upload is too big.
> Upload progress bar don't report max size exception
> ---------------------------------------------------
>
> Key: WICKET-3594
> URL: https://issues.apache.org/jira/browse/WICKET-3594
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.17, 1.5-RC3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
>
> Can be reproduced at http://wicketstuff.org/wicket/upload/single simple trying to upload a file higher than 100k
> http://apache.markmail.org/search/?q=UploadProgressBar+Possible+Bug#query:UploadProgressBar%20Possible%20Bug+page:1+mid:ehfjyvugtncam5gr+state:results
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3594) Upload progress bar don't report
max size exception
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032526#comment-13032526 ]
Pedro Santos commented on WICKET-3594:
--------------------------------------
@pedro: (...)The container is always reading the
entire input stream regardless of the application doing it or not.
I talked about in IRC and Igor suggested me to close the stream if it
exceed the max limit, but by doing so the client gets no response and
browser shows a page saying that the connection to server are lost.
@phil
> (...) instead of closing the
> stream can you at least make sure the progress bar is invisible and let the
> container do its thing?
@pedro
Sure, I will try this solution by hiding the progress bar and presenting a message explaining about the exceeded limit. What I didn't understood while playing some uploads is: why browser goes out the page to present an connection lost page if the form was submitted inside an iframe?
I will try also redirect the page an latter read the stream just to close it (sounds lame to me but maybe works).
> Upload progress bar don't report max size exception
> ---------------------------------------------------
>
> Key: WICKET-3594
> URL: https://issues.apache.org/jira/browse/WICKET-3594
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.17, 1.5-RC3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
>
> Can be reproduced at http://wicketstuff.org/wicket/upload/single simple trying to upload a file higher than 100k
> http://apache.markmail.org/search/?q=UploadProgressBar+Possible+Bug#query:UploadProgressBar%20Possible%20Bug+page:1+mid:ehfjyvugtncam5gr+state:results
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira