You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/03/01 00:26:43 UTC

[GitHub] rominparekh commented on a change in pull request #115: [Minor] Add UT: UpdateSchemaWithComplexStruct

rominparekh commented on a change in pull request #115: [Minor] Add UT: UpdateSchemaWithComplexStruct
URL: https://github.com/apache/incubator-iceberg/pull/115#discussion_r261441094
 
 

 ##########
 File path: core/src/test/java/com/netflix/iceberg/hadoop/TestHadoopCommits.java
 ##########
 @@ -242,4 +246,50 @@ public void testMergeAppend() throws Exception {
     Assert.assertEquals("Current snapshot should contain 1 merged manifest",
         1, metadata.currentSnapshot().manifests().size());
   }
+
+  @Test
+  public void testSchemaUpdateComplexType() throws Exception {
+    Assert.assertTrue("Should create v1 metadata",
+            version(1).exists() && version(1).isFile());
 
 Review comment:
   +1. Fixed indentation to 2 spaces.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org