You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhenlineo (via GitHub)" <gi...@apache.org> on 2023/07/13 00:01:27 UTC

[GitHub] [spark] zhenlineo commented on a diff in pull request #41969: [SPARK-44398][CONNECT] Scala foreachBatch API

zhenlineo commented on code in PR #41969:
URL: https://github.com/apache/spark/pull/41969#discussion_r1261833178


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -215,15 +215,24 @@ message WriteStreamOperationStart {
   }
 
   StreamingForeachWriter foreach_writer = 13;
+  StreamingForeachFunction foreach_batch = 14;

Review Comment:
   I think you can rename the protos if it has not yet be released.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org