[GitHub] [netbeans] matthiasblaesing commented on pull request #2934: [NETBEANS-5655] Fix build error caused by non-ASCII quotes in an arch.xml file

[GitBox <gi...@apache.org>]

matthiasblaesing commented on pull request #2934:
URL: https://github.com/apache/netbeans/pull/2934#issuecomment-832183351


   Sorry I disagree - sticking to ASCII will keep the computer world in a broken world. Unicode is 20+ years and we still discuss whether valid unicode handling can be worked around by using ascii? In this case it is even worse - one of the mortal sins of XML processsing happend: Instead of using an xml processor, plain text processing was used, ignoring encodings and such.
   
   Assuming all input files are UTF-8 (ascii is by construction UTF-8, UTF-8 is the dafult encoding for XML), you could see if the ant concat task with platform encoding breaks this:
   
   https://github.com/apache/netbeans/blob/4fd403dc36af972e7d75ec4e96b1f59a37a4e155/nbbuild/javadoctools/build.xml#L128-L139
   
   `concat` has the parameters `encoding` and `outputencoding`. I would set both to `UTF-8`, this should match the default behavior on linux. That will still be broken, but slightly less (assuming it even helps).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists