You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/01/02 07:22:02 UTC
[GitHub] [zeppelin] Reamer commented on a change in pull request #4007: [ZEPPELIN-5180] - Improve Kerberos debug messages
Reamer commented on a change in pull request #4007:
URL: https://github.com/apache/zeppelin/pull/4007#discussion_r550853905
##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/KerberosInterpreter.java
##########
@@ -133,17 +133,19 @@ private ScheduledExecutorService startKerberosLoginThread() {
public Object call() throws Exception {
if (runKerberosLogin()) {
- logger.info("Ran runKerberosLogin command successfully.");
+ LOGGER.info("Ran runKerberosLogin command successfully.");
kinitFailCount = 0;
// schedule another kinit run with a fixed delay.
+ LOGGER.info("Scheduling Kerberos ticket refresh thread with interval " +
+ getKerberosRefreshInterval() + " ms");
scheduledExecutorService
.schedule(this, getKerberosRefreshInterval(), TimeUnit.MILLISECONDS);
} else {
kinitFailCount++;
- logger.info("runKerberosLogin failed for " + kinitFailCount + " time(s).");
+ LOGGER.info("runKerberosLogin failed for " + kinitFailCount + " time(s).");
Review comment:
Please use the parameterized message.
##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/KerberosInterpreter.java
##########
@@ -106,7 +106,7 @@ private Integer kinitFailThreshold() {
private Long getTimeAsMs(String time) {
if (time == null) {
- logger.error("Cannot convert to time value.", time);
+ LOGGER.error("Cannot convert to time value.", time);
Review comment:
'time' makes no sense with this output.
##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/KerberosInterpreter.java
##########
@@ -133,17 +133,19 @@ private ScheduledExecutorService startKerberosLoginThread() {
public Object call() throws Exception {
if (runKerberosLogin()) {
- logger.info("Ran runKerberosLogin command successfully.");
+ LOGGER.info("Ran runKerberosLogin command successfully.");
kinitFailCount = 0;
// schedule another kinit run with a fixed delay.
+ LOGGER.info("Scheduling Kerberos ticket refresh thread with interval " +
Review comment:
Please use the parameterized method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org