You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/11/02 09:24:53 UTC

[GitHub] [drill] jnturton opened a new pull request, #2697: DRILL-8299: HashMap key type mismatch in MetadataContext

jnturton opened a new pull request, #2697:
URL: https://github.com/apache/drill/pull/2697

   # [DRILL-8299](https://issues.apache.org/jira/browse/DRILL-8299): HashMap key type mismatch in MetadataContext
   
   ## Description
   
   The Map dirModifCheckMap is keyed using a HDFS Path instance, not a string. This updates accessing code accordingly.
   
   ## Documentation
   N/A
   
   ## Testing
   Existing unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2697: DRILL-8299: HashMap key type mismatch in MetadataContext

Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2697:
URL: https://github.com/apache/drill/pull/2697#issuecomment-1300446343

   > @jnturton Thanks for submitting this. I approved this but what were the implications of this bug?
   
   @cgivre the bug had a performance implication. A cache recording which directories already had their modification times checked for the purpose of determining where Parquet metadata cache files (created by `REFRESH TABLE METADATA`) need updating was being accessed using objects of wrong type that, barring an unexpected override of Path.equals(), meant that the cache had a 100% miss rate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2697: DRILL-8299: HashMap key type mismatch in MetadataContext

Posted by GitBox <gi...@apache.org>.
cgivre commented on PR #2697:
URL: https://github.com/apache/drill/pull/2697#issuecomment-1300262791

   @jnturton Thanks for submitting this.  I approved this but what were the implications of this bug?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre merged pull request #2697: DRILL-8299: HashMap key type mismatch in MetadataContext

Posted by GitBox <gi...@apache.org>.
cgivre merged PR #2697:
URL: https://github.com/apache/drill/pull/2697


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org