You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2005/01/04 14:51:01 UTC
Re: svn commit: r124080 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c
On 4 Jan 2005 09:58:09 -0000, jfclere@apache.org <jf...@apache.org> wrote:
> Author: jfclere
> Date: Tue Jan 4 01:58:01 2005
> New Revision: 124080
>
> URL: http://svn.apache.org/viewcvs?view=rev&rev=124080
> Log:
> Add including of util_charset.h otherwise ap_hdrs_from_ascii is not defined.
>
> Modified:
> httpd/httpd/trunk/modules/cache/mod_disk_cache.c
>
> Modified: httpd/httpd/trunk/modules/cache/mod_disk_cache.c
> Url: http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/cache/mod_disk_cache.c?view=diff&rev=124080&p1=httpd/httpd/trunk/modules/cache/mod_disk_cache.c&r1=124079&p2=httpd/httpd/trunk/modules/cache/mod_disk_cache.c&r2=124080
> ==============================================================================
> --- httpd/httpd/trunk/modules/cache/mod_disk_cache.c (original)
> +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.c Tue Jan 4 01:58:01 2005
> @@ -20,6 +20,10 @@
> #include "util_filter.h"
> #include "util_script.h"
>
> +#if APR_CHARSET_EBCDIC
> +#include "util_charset.h"
> +#endif
why not include it unconditionally?
Re: svn commit: r124080 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Jeff Trawick wrote:
> On 4 Jan 2005 09:58:09 -0000, jfclere@apache.org <jf...@apache.org> wrote:
>
>>Author: jfclere
>>Date: Tue Jan 4 01:58:01 2005
>>New Revision: 124080
>>
>>URL: http://svn.apache.org/viewcvs?view=rev&rev=124080
>>Log:
>>Add including of util_charset.h otherwise ap_hdrs_from_ascii is not defined.
>>
>>Modified:
>> httpd/httpd/trunk/modules/cache/mod_disk_cache.c
>>
>>Modified: httpd/httpd/trunk/modules/cache/mod_disk_cache.c
>>Url: http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/cache/mod_disk_cache.c?view=diff&rev=124080&p1=httpd/httpd/trunk/modules/cache/mod_disk_cache.c&r1=124079&p2=httpd/httpd/trunk/modules/cache/mod_disk_cache.c&r2=124080
>>==============================================================================
>>--- httpd/httpd/trunk/modules/cache/mod_disk_cache.c (original)
>>+++ httpd/httpd/trunk/modules/cache/mod_disk_cache.c Tue Jan 4 01:58:01 2005
>>@@ -20,6 +20,10 @@
>> #include "util_filter.h"
>> #include "util_script.h"
>>
>>+#if APR_CHARSET_EBCDIC
>>+#include "util_charset.h"
>>+#endif
>
>
> why not include it unconditionally?
>
>
Just my bad. util_charset.h has already the needed #if APR_CHARSET_EBCDIC.
Cheers
Jean-Frederic