You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by jo...@apache.org on 2022/04/08 17:24:26 UTC
[arrow] branch master updated: MINOR: [R] Fix compiler warning/CMD check NOTE when compiling with ARROW_R_WITH_ENGINE
This is an automated email from the ASF dual-hosted git repository.
jonkeane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new d197ad31c3 MINOR: [R] Fix compiler warning/CMD check NOTE when compiling with ARROW_R_WITH_ENGINE
d197ad31c3 is described below
commit d197ad31c3d7c16ecee74cb76a71ce397e905b3b
Author: Dewey Dunnington <de...@fishandwhistle.net>
AuthorDate: Fri Apr 8 12:24:17 2022 -0500
MINOR: [R] Fix compiler warning/CMD check NOTE when compiling with ARROW_R_WITH_ENGINE
After ARROW-16033 (#12721) we get this compiler warning when compiling with `ARROW_R_WITH_ENGINE`:
```
compute-exec.cpp:304:17: warning: 'Init' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
arrow::Status Init(const std::shared_ptr<arrow::Schema>& schema) {
^
/Users/deweydunnington/.r-arrow-dev-build/dist/include/arrow/compute/exec/options.h:153:18: note: overridden virtual function is here
virtual Status Init(const std::shared_ptr<Schema>& schema) = 0;
^
1 warning generated.
```
This PR just adds the requisite `override`.
Closes #12823 from paleolimbot/r-minor-override
Authored-by: Dewey Dunnington <de...@fishandwhistle.net>
Signed-off-by: Jonathan Keane <jk...@gmail.com>
---
r/src/compute-exec.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/r/src/compute-exec.cpp b/r/src/compute-exec.cpp
index a1a679144d..e7d8df55bb 100644
--- a/r/src/compute-exec.cpp
+++ b/r/src/compute-exec.cpp
@@ -301,7 +301,7 @@ class AccumulatingConsumer : public compute::SinkNodeConsumer {
public:
const std::vector<std::shared_ptr<arrow::RecordBatch>>& batches() { return batches_; }
- arrow::Status Init(const std::shared_ptr<arrow::Schema>& schema) {
+ arrow::Status Init(const std::shared_ptr<arrow::Schema>& schema) override {
schema_ = schema;
return arrow::Status::OK();
}