[whimsy] branch master updated: Wrong check for committee existence

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 0088c99  Wrong check for committee existence
0088c99 is described below

commit 0088c99f54a562e45eda2ebd3450c21e37a76952
Author: Sebb <se...@apache.org>
AuthorDate: Sun Feb 10 20:51:36 2019 +0000

    Wrong check for committee existence
    
    Must check committee-info.txt as dn() uses ou=projects
    and ou=pmc is disappearing as have guinea pigs
---
 lib/whimsy/asf/ldap.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 5abb14d..c37785c 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1266,8 +1266,8 @@ module ASF
     # return committee only if it actually exists
     def self.[] name
       committee = super
-      # cheaper/safer check than looking at members
-      committee.dn ? committee : nil
+      # Cannot rely on presence/absence of LDAP record as projects includes podlings
+      (ASF::Committee.pmcs+ASF::Committee.nonpmcs).map(&:name).include?(name) ? committee : nil
     end
 
     # setter for members attribute, should only be used by