You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2024/03/13 15:06:53 UTC
[PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
wgtmac opened a new pull request, #40508:
URL: https://github.com/apache/arrow/pull/40508
### Rationale for this change
This PR aims to upgrade to a new major version of Apache ORC: https://orc.apache.org/news/2024/03/08/ORC-2.0.0/
### What changes are included in this PR?
This PR upgrades ORC dependency from 1.9.2 to 2.0.0.
### Are these changes tested?
Pass the CIs.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2012996011
You can probably split the Java and C++ parts of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025199894
Revision: f07c512421ad1d7c2a3ea2d8afe95c38aa477aa5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-05df38c481](https://github.com/ursacomputing/crossbow/branches/all?query=actions-05df38c481)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468109385/job/23200319756)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468109112/job/23200318990)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468109094/job/23200318919)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468109016/job/23200318778)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468108930/job/23200318677)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025269658
> So it seems this breaks the macOS wheel builds for Python 3.8, 3.9 and 3.10 (but not 3.11 and 3.12). The error is related to a protobuf symbol, and ORC uses protobuf:
>
> ```
> ImportError: dlopen(/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/test-arm64-env/lib/python3.8/site-packages/pyarrow/lib.cpython-38-darwin.so, 0x0002): symbol not found in flat namespace '__ZN6google8protobuf2io19ZeroCopyInputStream8ReadCordEPN4absl12lts_202401164CordEi'
> ```
>
> The symbol is `google::protobuf::io::ZeroCopyInputStream::ReadCord(absl::lts_20240116::Cord*, int)`.
>
> @wgtmac Is ORC 2.0 building its own protobuf from scratch? Answer: it should not, we're passing `PROTOBUF_HOME` to ORC's CMake.
Right, ORC should use what we provide here: https://github.com/apache/arrow/blob/a9b2cc2c962f064c3fa5504909f122e9bcabda3f/cpp/cmake_modules/ThirdpartyToolchain.cmake#L4386-L4396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025230224
Revision: 19adc6f2f4a7c1b15b2e9072a6333e110a02052a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d69b839505](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d69b839505)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468293433/job/23200957039)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468292882/job/23200955849)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468293779/job/23200958143)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468292929/job/23200955775)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468292858/job/23200955852)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1994835371
That said, I think what we've done is to hold off on package updates requiring Java 8 for now, since we're still supporting Java 8...We were trying to drop Java 8 support but some people spoke out against. Maybe we need to revisit that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024718965
Revision: 302db24cd8c152c6e8acff64498c745263b5dd5f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1bec73b67c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1bec73b67c)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875610/job/23190413587)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876052/job/23190453580)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/8464874966/job/23190408408)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875793/job/23190451951)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875979/job/23190452874)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875408/job/23190411813)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875267/job/23190410387)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875813/job/23190452104)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875165/job/23190409395)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875606/job/23190413545)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875431/job/23190412007)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876044/job/23190453179)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875204/job/23190409698)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875115/job/23190409097)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876170/job/23190453921)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875322/job/23190410723)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875052/job/23190408638)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875345/job/23190411009)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875049/job/23190408691)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875468/job/23190412397)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875340/job/23190410919)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/runs/23190410471)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875346/job/23190411002)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/runs/23190413553)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/23190412021)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875442/job/23190412227)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875206/job/23190409628)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875018/job/23190408608)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876249/job/23190454055)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875945/job/23190452852)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875485/job/23190412443)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875132/job/23190409167)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464874998/job/23190408437)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875243/job/23190410054)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875554/job/23190412864)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875062/job/23190408841)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875936/job/23190452757)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875219/job/23190409703)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875821/job/23190452175)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876090/job/23190453693)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876226/job/23190453971)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875417/job/23190411907)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876130/job/23190453780)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875875/job/23190452442)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875581/job/23190413235)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875300/job/23190410575)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875891/job/23190452535)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876050/job/23190453228)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876056/job/23190453593)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875374/job/23190411414)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875786/job/23190451856)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875155/job/23190409190)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875726/job/23190451715)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875264/job/23190410159)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876051/job/23190453258)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875809/job/23190452006)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875584/job/23190413238)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875562/job/23190413000)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875268/job/23190410231)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464876539/job/23190454063)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875373/job/23190411302)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025193449
@github-actions crossbow submit wheel-macos-*-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #40508:
URL: https://github.com/apache/arrow/pull/40508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025174551
Revision: e3bc6253c8c91709b04ff4499b9daafc1a2dc666
Submitted crossbow builds: [ursacomputing/crossbow @ actions-06d4c0c9e8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-06d4c0c9e8)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8467961790/job/23199834960)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8467961821/job/23199834980)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8467961819/job/23199835001)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8467962380/job/23199836100)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8467961919/job/23199835339)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1998677924
Revision: 7203fe6fd4575fd8cf7d562c1c731ad379d26d20
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c8f70cc49c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c8f70cc49c)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8289254609/job/22685344209)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8289254682/job/22685344555)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8289254570/job/22685343947)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8289254808/job/22685344574)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8289254730/job/22685344565)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1994695444
OK, I'm wrong:
```
[INFO] Arrow Performance Benchmarks ....................... SKIPPED
[INFO] Arrow Java C Data Interface ........................ SUCCESS [ 57.354 s]
[INFO] Arrow Orc Adapter .................................. FAILURE [ 35.491 s]
[INFO] Arrow Gandiva ...................................... SUCCESS [01:26 min]
[INFO] Arrow Java Dataset ................................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:03 min (Wall Clock)
[INFO] Finished at: 2024-03-13T15:23:50Z
[INFO] ------------------------------------------------------------------------
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:testCompile (default-testCompile) on project arrow-orc: Compilation failure
Error: /arrow/java/adapter/orc/src/test/java/org/apache/arrow/adapter/orc/OrcReaderTest.java:[40,21] error: cannot access OrcFile
Error: bad class file: /root/.m2/repository/org/apache/orc/orc-core/2.0.0/orc-core-2.0.0.jar(/org/apache/orc/OrcFile.class)
Error: class file has wrong version 61.0, should be 53.0
Error: Please remove or make sure it appears in the correct subdirectory of the classpath.
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn <args> -rf :arrow-orc
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024776464
Hmm, weirdly, the 3.10 build succeeded when restarted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025081210
Ok, so it really seems non-deterministic: over 4 macOS wheel builds for Python 3.8, 3 were failed and 1 was successful:
https://github.com/ursacomputing/crossbow/actions/runs/8464875945/attempts/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025223834
Okay, I think I've found it:
* ORC build on [successful wheel build](https://productionresultssa15.blob.core.windows.net/actions-results/543076d3-56af-4fbc-8260-78e45bc3fda2/workflow-job-run-ca395085-040a-526b-2ce8-bdc85f692774/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-28T13%3A52%3A05Z&sig=XlDLT8YXosUno5bsHkMdQAJUgREfZstBGDDo0xWoaCA%3D&sp=r&spr=https&sr=b&st=2024-03-28T13%3A42%3A00Z&sv=2021-12-02):
```
2024-03-28T13:34:25.3459520Z -- PROTOBUF_HOME: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx-static-release
2024-03-28T13:34:25.3460120Z -- Could NOT find Protobuf (missing: Protobuf_DIR)
2024-03-28T13:34:25.3460830Z -- Found the Protobuf headers: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx-static-release/include
2024-03-28T13:34:25.3461910Z -- Found the Protobuf library: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx-static-release/lib/libprotobuf.a
2024-03-28T13:34:25.3463000Z -- Found the Protoc library: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx-static-release/lib/libprotoc.a
2024-03-28T13:34:25.3464060Z -- Found the Protoc executable: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx/tools/protobuf/protoc
2024-03-28T13:34:25.3465220Z -- Found the Protobuf static library: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx-static-release/lib/libprotobuf.a
2024-03-28T13:34:25.3466370Z -- Found the Protoc static library: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx-static-release/lib/libprotoc.a
```
* ORC build on [failed wheel build](https://productionresultssa9.blob.core.windows.net/actions-results/f4aa3d21-d458-443e-a829-9102cd02db40/workflow-job-run-ca395085-040a-526b-2ce8-bdc85f692774/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-03-28T13%3A46%3A19Z&sig=QUAj6fWpvA%2FnyLNK8Duevklu8hJ1GkpwXfH67Th4wwY%3D&sp=r&spr=https&sr=b&st=2024-03-28T13%3A36%3A14Z&sv=2021-12-02):
```
2024-03-28T13:33:59.5638710Z -- PROTOBUF_HOME: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/vcpkg/installed/arm64-osx-static-release
2024-03-28T13:33:59.5643750Z -- Found the Protobuf headers: /opt/homebrew/include
2024-03-28T13:33:59.5644210Z -- Found the Protobuf library: protobuf::libprotobuf
2024-03-28T13:33:59.5644590Z -- Found the Protoc library: protobuf::libprotoc
2024-03-28T13:33:59.5644960Z -- Found the Protoc executable: protobuf::protoc
```
Note `/opt/homebrew/include`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024769919
So it seems this breaks the macOS wheel builds for Python 3.8, 3.9 and 3.10 (but not 3.11 and 3.12).
The error is related to a protobuf symbol, and ORC uses protobuf:
```
ImportError: dlopen(/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/test-arm64-env/lib/python3.8/site-packages/pyarrow/lib.cpython-38-darwin.so, 0x0002): symbol not found in flat namespace '__ZN6google8protobuf2io19ZeroCopyInputStream8ReadCordEPN4absl12lts_202401164CordEi'
```
The symbol is `google::protobuf::io::ZeroCopyInputStream::ReadCord(absl::lts_20240116::Cord*, int)`.
@wgtmac Is ORC 2.0 building its own protobuf from scratch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025176225
I also see the following CMake warning which is possibly related:
```
2024-03-28T09:13:53.3314130Z CMake Warning:
2024-03-28T09:13:53.3314590Z Manually-specified variables were not used by the project:
2024-03-28T09:13:53.3314850Z
2024-03-28T09:13:53.3314940Z ORC_PROTOBUF_EXECUTABLE
2024-03-28T09:13:53.3315080Z
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024791234
I'm trying to find any visible differences between https://github.com/ursacomputing/crossbow/actions/runs/8464875206/job/23191249944 (successful 3.10 build) and https://github.com/ursacomputing/crossbow/actions/runs/8464875206/job/23190409628 (failing 3.10 build) but nothing obvious stands out. The library versions seem exactly identical.
I'm going to restart a second time to see if we get a new failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024716495
Revision: 302db24cd8c152c6e8acff64498c745263b5dd5f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2dc4487aef](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2dc4487aef)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875295/job/23190410403)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875585/job/23190413120)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875616/job/23190413637)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/23190411261)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875379/job/23190411489)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875380/job/23190411620)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875514/job/23190412703)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875419/job/23190411890)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875229/job/23190409917)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875423/job/23190412123)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875405/job/23190411662)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875166/job/23190409439)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875504/job/23190412471)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875238/job/23190409889)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875377/job/23190411401)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875254/job/23190410170)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/8464875224/job/23190409882)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025225991
@github-actions crossbow submit wheel-macos-*-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #40508:
URL: https://github.com/apache/arrow/pull/40508#discussion_r1542216589
##########
java/adapter/orc/pom.xml:
##########
@@ -38,7 +38,7 @@
<dependency>
<groupId>org.apache.orc</groupId>
<artifactId>orc-core</artifactId>
- <version>1.9.2</version>
+ <version>2.0.0</version>
Review Comment:
```suggestion
<version>1.9.2</version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025100081
So, I grabbed two 3.8 wheel files: one successful and one failed. Those wheels contain differences in the three following files: `libarrow.1600.dylib`, `libarrow_flight.1600.dylib` and `libarrow_substrait.1600.dylib`.
I'm going to try to find out more about this, but there doesn't seem to be an easy way to inspect macOS dylib files under Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024712245
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1996235369
I think what's going to have to happen is that if someone really needs Java 8 support, they are going to have to maintain the fork or otherwise come up with a strategy, because eventually these CVE fixes pile up and we won't be able to defer the issue any longer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025462779
@github-actions crossbow submit -g python -g wheel -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2026840747
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 4f39e6eac9f24b37b0866c432c030de2eaef78e1.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23231609401) has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025238056
Revision: a96c669b239894fbad64b9db0c926745ade4ae49
Submitted crossbow builds: [ursacomputing/crossbow @ actions-398e529e10](https://github.com/ursacomputing/crossbow/branches/all?query=actions-398e529e10)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468340052/job/23201120348)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468339959/job/23201120087)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468340126/job/23201120661)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468340018/job/23201120231)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8468340317/job/23201121367)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025233078
@github-actions crossbow submit wheel-macos-*-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1996224454
As `orc-core` is only used in the test scope, perhaps we can leave it to stay at 1.9.x which is the last major version with java 8 support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024711626
@github-actions crossbow submit -g python -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025472921
Revision: 48f6387c5d80d2f828205a34d130462c54145895
Submitted crossbow builds: [ursacomputing/crossbow @ actions-33cf00f7e6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-33cf00f7e6)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489260/job/23204938707)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489592/job/23204941982)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490089/job/23204990966)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489212/job/23204938400)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489492/job/23204941336)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/23204943515)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489218/job/23204938685)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488797/job/23204935028)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490097/job/23204990964)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490397/job/23204992535)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489703/job/23204988815)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489210/job/23204938499)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489547/job/23204941619)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489435/job/23204939871)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489583/job/23204942016)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489061/job/23204936842)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489545/job/23204941736)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488736/job/23204934668)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489810/job/23204989492)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489672/job/23204988728)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489289/job/23204939573)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489561/job/23204941687)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489167/job/23204938427)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489385/job/23204939652)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488899/job/23204935919)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488827/job/23204935378)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490512/job/23204993301)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490219/job/23204992016)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489059/job/23204936916)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488859/job/23204935724)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/runs/23204939983)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489757/job/23204989059)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489356/job/23204939572)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/runs/23204937152)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489781/job/23204989146)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490212/job/23204992030)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490108/job/23204991115)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489471/job/23204941345)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/23204939201)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490399/job/23204992556)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488948/job/23204936317)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489825/job/23204989361)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489038/job/23204936835)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490424/job/23204992561)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489849/job/23204989978)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489529/job/23204939881)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490263/job/23204992006)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489967/job/23204989953)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490358/job/23204992307)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490228/job/23204991994)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489177/job/23204938417)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488771/job/23204935395)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488761/job/23204934677)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490210/job/23204991331)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489359/job/23204939600)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490094/job/23204990974)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488677/job/23204934194)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489141/job/23204937639)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489116/job/23204937593)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489792/job/23204989395)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489550/job/23204941691)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490365/job/23204992349)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490075/job/23204989959)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469491067/job/23204993315)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488671/job/23204934110)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469491016/job/23204993298)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489436/job/23204941311)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488927/job/23204936320)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489076/job/23204937155)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488856/job/23204935743)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489845/job/23204989991)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488769/job/23204934699)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488680/job/23204934179)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489069/job/23204936858)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490261/job/23204992326)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488959/job/23204936310)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489517/job/23204941371)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469490313/job/23204992310)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469488627/job/23204933887)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8469489075/job/23204937048)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024256175
Just reverted the java module change. Thanks for the reminder! @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2024794270
(I'll note that both ORC 1.9.3 and 2.0.0 seem to use `google::protobuf::io::ZeroCopyInputStream`, so it's not a new feature)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1998676045
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2009564747
I think we're going to revisit Java 8 in the next 3-6 months so we can include this PR in that effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025145409
So, I'm able to get some insight by using the `strings` command followed by some processing:
```console
$ strings wheel-3.8-successful/pyarrow/libarrow.1600.dylib | \grep "^_\w" | sort | uniq | sed -E 's/^_+/_/g' | c++filt > strings-successful.txt
$ strings wheel-3.8-failed/pyarrow/libarrow.1600.dylib | \grep "^_\w" | sort | uniq | sed -E 's/^_+/_/g' | c++filt > strings-failed.txt
```
Then I can diff `strings-failed.txt` and `strings-successful.txt` to get an idea of the differences:
```console
$ diff --color -u strings-failed.txt strings-successful.txt
```
And amongst the changes some have to do with the protobuf-generated code for ORC:
```diff
@@ -60127,232 +59930,265 @@
orc::proto::Encryption::GetMetadata() const
orc::proto::Encryption::ByteSizeLong() const
orc::proto::Encryption::GetClassData() const
+orc::proto::Encryption::GetCachedSize() const
orc::proto::Encryption::IsInitialized() const
-orc::proto::Encryption::AccessCachedSize() const
+orc::proto::Encryption::SetCachedSize(int) const
```
(note: "-" lines are the failed wheel build, "+" lines are the successful wheel build)
This indicates that between the failed and successful build, two different versions of the protobuf compiler were invoked:
- the failed build uses a protobuf compiler that contains https://github.com/protocolbuffers/protobuf/commit/ecd106bd49b700b862f1a1241800988bb8ade120 (" Replace GetCachedSize+SetCachedSize with a single AccessCachedSize function"), therefore is v26.1 or later
- the successful build uses a previous protobuf compiler, therefore v26.0 or earlier.
Now to understand where these two different protobuf versions come from... @kou @assignUser any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025169926
@github-actions crossbow submit wheel-macos-*-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2025227895
Yuck, this PR is based on an old version of the git repo...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-2026428694
Thank you for the investigation! @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1994832930
Hmm, that is test scope, and the other builds pass. So I guess that pipeline uses Java 8 and we could maybe exclude the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1996234594
I added this to the list at https://github.com/apache/arrow/issues/38051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40507: [C++][ORC] Upgrade ORC to 2.0.0 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #40508:
URL: https://github.com/apache/arrow/pull/40508#issuecomment-1994633553
The Apache ORC java library has dropped Java 8 support from v2.0.0. However, I don't think this is an issue here as the orc-core java dependency is only used in the test scope. Am I correct? @lidavidm @jduo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org