You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "PHILO-HE (via GitHub)" <gi...@apache.org> on 2024/05/31 07:15:14 UTC
[PR] [WIP] Add CMake format checker [incubator-gluten]
PHILO-HE opened a new pull request, #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941
## What changes were proposed in this pull request?
Use cmake-format to check CMakLists.txt & *.cmake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2167072532
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5941_time.csv</font></td>
<td><font color=#000000>log/native_master_06_13_2024_142cf0fbc_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>37.02</font></td>
<td><font color=#6F9915>35.57</font></td>
<td><font color=#6F9915>-1.454</font></td>
<td><font color=#6F9915>96.07%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>23.57</font></td>
<td><font color=#F92663>23.78</font></td>
<td><font color=#F92663>0.208</font></td>
<td><font color=#F92663>100.88%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>38.90</font></td>
<td><font color=#F92663>39.61</font></td>
<td><font color=#F92663>0.706</font></td>
<td><font color=#F92663>101.82%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>31.53</font></td>
<td><font color=#F92663>32.76</font></td>
<td><font color=#F92663>1.234</font></td>
<td><font color=#F92663>103.91%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>71.12</font></td>
<td><font color=#6F9915>67.54</font></td>
<td><font color=#6F9915>-3.582</font></td>
<td><font color=#6F9915>94.96%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>6.92</font></td>
<td><font color=#F92663>9.42</font></td>
<td><font color=#F92663>2.493</font></td>
<td><font color=#F92663>136.02%</font></td>
</tr>
<tr>
<td><font color=#F92663>q7</font></td>
<td><font color=#F92663>80.40</font></td>
<td><font color=#F92663>80.69</font></td>
<td><font color=#F92663>0.298</font></td>
<td><font color=#F92663>100.37%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>86.33</font></td>
<td><font color=#6F9915>84.77</font></td>
<td><font color=#6F9915>-1.557</font></td>
<td><font color=#6F9915>98.20%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>123.10</font></td>
<td><font color=#6F9915>120.70</font></td>
<td><font color=#6F9915>-2.397</font></td>
<td><font color=#6F9915>98.05%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>46.44</font></td>
<td><font color=#6F9915>45.25</font></td>
<td><font color=#6F9915>-1.182</font></td>
<td><font color=#6F9915>97.46%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q11</font></td>
<td><font color=#6F9915>19.84</font></td>
<td><font color=#6F9915>19.79</font></td>
<td><font color=#6F9915>-0.058</font></td>
<td><font color=#6F9915>99.71%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>29.47</font></td>
<td><font color=#6F9915>27.92</font></td>
<td><font color=#6F9915>-1.555</font></td>
<td><font color=#6F9915>94.72%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>37.04</font></td>
<td><font color=#F92663>39.43</font></td>
<td><font color=#F92663>2.390</font></td>
<td><font color=#F92663>106.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>22.36</font></td>
<td><font color=#6F9915>18.98</font></td>
<td><font color=#6F9915>-3.378</font></td>
<td><font color=#6F9915>84.89%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>29.27</font></td>
<td><font color=#F92663>33.04</font></td>
<td><font color=#F92663>3.772</font></td>
<td><font color=#F92663>112.89%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>13.84</font></td>
<td><font color=#F92663>13.85</font></td>
<td><font color=#F92663>0.008</font></td>
<td><font color=#F92663>100.06%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>102.71</font></td>
<td><font color=#6F9915>101.57</font></td>
<td><font color=#6F9915>-1.139</font></td>
<td><font color=#6F9915>98.89%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>148.31</font></td>
<td><font color=#6F9915>144.97</font></td>
<td><font color=#6F9915>-3.339</font></td>
<td><font color=#6F9915>97.75%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.61</font></td>
<td><font color=#F92663>13.79</font></td>
<td><font color=#F92663>0.185</font></td>
<td><font color=#F92663>101.36%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>28.57</font></td>
<td><font color=#6F9915>26.68</font></td>
<td><font color=#6F9915>-1.894</font></td>
<td><font color=#6F9915>93.37%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>256.94</font></td>
<td><font color=#F92663>260.83</font></td>
<td><font color=#F92663>3.888</font></td>
<td><font color=#F92663>101.51%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>12.04</font></td>
<td><font color=#F92663>13.91</font></td>
<td><font color=#F92663>1.876</font></td>
<td><font color=#F92663>115.59%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1259.33</font></td>
<td><font color=#6F9915>1254.85</font></td>
<td><font color=#6F9915>-4.478</font></td>
<td><font color=#6F9915>99.64%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144395149
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144393256
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#discussion_r1625203396
##########
.github/workflows/code_style.yml:
##########
@@ -14,43 +14,56 @@
# limitations under the License.
name: Code style checks
-
on:
- pull_request
-
+ pull_request:
+ paths:
+ - '.github/workflows/code_style.yml'
+ - 'cpp/**'
+ - 'cpp-ch/**'
concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
cancel-in-progress: true
jobs:
- formatting-check:
- name: Formatting Check
+ CPP-format-check:
+ name: CPP Format Check
runs-on: ubuntu-latest
strategy:
matrix:
path:
- - check: 'cpp/core'
- exclude: ''
- - check: 'cpp/velox'
+ - check: 'cpp'
exclude: ''
steps:
- uses: actions/checkout@v4
- - name: Run clang-format style check for C/C++ programs.
+ - name: Run clang-format style check for C/C++
uses: jidicula/clang-format-action@v4.11.0
with:
clang-format-version: '15'
check-path: ${{ matrix.path['check'] }}
fallback-style: 'Google' # optional
- license-check:
- name: License Header Check
+ CMake-format-check:
+ name: CMake Format Check
runs-on: ubuntu-latest
-
+ container: ubuntu:22.04
steps:
- - uses: actions/checkout@v3
-
- - name: Check License Header
+ - name: Install tools
+ run: |
+ apt update -y
+ apt install git python3-pip -y
+ pip3 install --user cmake-format
+ - uses: actions/checkout@v4
+ - name: Check CMake format
run: |
- git fetch --recurse-submodules=no origin main ${{github.event.pull_request.base.sha}}
- pip install regex
- dev/check.sh ${{github.event.pull_request.base.sha}}
+ git config --global --add safe.directory $GITHUB_WORKSPACE
+ cd $GITHUB_WORKSPACE/
+ fileList=$(find ./cpp ./cpp-ch -name CMakeLists.txt -o -name *.cmake)
Review Comment:
@zzcclp, I'm adding to CI job to format CMake code (CMakeLists.txt & *.cmake), which also covers cpp-ch module. Please take a look to see if it's ok to you. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2167000072
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144427846
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144475971
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144438560
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144418029
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2167019708
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2141370729
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144413958
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144398184
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144520159
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "liuneng1994 (via GitHub)" <gi...@apache.org>.
liuneng1994 commented on code in PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#discussion_r1630740681
##########
cpp-ch/CMakeLists.txt:
##########
@@ -27,93 +29,93 @@ message("CH_COMMIT=${CH_COMMIT}")
project(libch LANGUAGES C CXX ASM)
file(GLOB clickhouse_files "${CH_SOURCE_DIR}/*")
-if ("${CH_SOURCE_DIR}" STREQUAL "${CMAKE_SOURCE_DIR}/ClickHouse")
- if (NOT clickhouse_files)
- execute_process(COMMAND git clone -b ${CH_BRANCH} --depth 3 https://github.com/${CH_ORG}/ClickHouse.git ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git reset --hard ${CH_COMMIT} WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git submodule update --init --force --depth 1 WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- else()
- execute_process(COMMAND git fetch origin ${CH_BRANCH} --depth 3 WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git checkout ${CH_BRANCH} WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git reset --hard ${CH_COMMIT} WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git submodule update --init --recursive --force --depth 1 WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- endif()
+if("${CH_SOURCE_DIR}" STREQUAL "${CMAKE_SOURCE_DIR}/ClickHouse")
+ if(NOT clickhouse_files)
+ execute_process(
+ COMMAND
+ git clone -b ${CH_BRANCH} --depth 3
+ https://github.com/${CH_ORG}/ClickHouse.git ${CH_SOURCE_DIR}
+ COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git reset --hard ${CH_COMMIT}
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git submodule update --init --force --depth 1
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ else()
+ execute_process(
+ COMMAND git fetch origin ${CH_BRANCH} --depth 3
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git checkout ${CH_BRANCH}
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git reset --hard ${CH_COMMIT}
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git submodule update --init --recursive --force --depth 1
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ endif()
else()
- if (NOT clickhouse_files)
- # Checking out *all* submodules takes > 5 min. Therefore, the smoke build ("FastTest") in CI initializes only the set of
- # submodules minimally needed for a build and we cannot assume here that all submodules are populated.
- message(ERROR "clickhouse ${CH_SOURCE_DIR} is missing or empty. to fix try run:")
- message(STATUS " git clone --recursive --depth 1 https://github.com/Kyligence/ClickHouse.git ${CMAKE_SOURCE_DIR}")
- endif()
+ if(NOT clickhouse_files)
+ # Checking out *all* submodules takes > 5 min. Therefore, the smoke build
+ # ("FastTest") in CI initializes only the set of submodules minimally needed
+ # for a build and we cannot assume here that all submodules are populated.
+ message(ERROR
+ "clickhouse ${CH_SOURCE_DIR} is missing or empty. to fix try run:")
+ message(
+ STATUS
+ " git clone --recursive --depth 1 https://github.com/Kyligence/ClickHouse.git ${CMAKE_SOURCE_DIR}"
+ )
+ endif()
endif()
-if (EXISTS "${CH_SOURCE_DIR}/utils/extern-local-engine")
- execute_process(COMMAND rm -rf ${CH_SOURCE_DIR}/utils/extern-local-engine)
-endif ()
-execute_process(COMMAND ln -s ${CMAKE_CURRENT_SOURCE_DIR}/local-engine ${CH_SOURCE_DIR}/utils/extern-local-engine COMMAND_ERROR_IS_FATAL ANY)
+if(EXISTS "${CH_SOURCE_DIR}/utils/extern-local-engine")
+ execute_process(COMMAND rm -rf ${CH_SOURCE_DIR}/utils/extern-local-engine)
+endif()
+execute_process(
+ COMMAND ln -s ${CMAKE_CURRENT_SOURCE_DIR}/local-engine
+ ${CH_SOURCE_DIR}/utils/extern-local-engine COMMAND_ERROR_IS_FATAL ANY)
-# execute_process(COMMAND find ${CMAKE_CURRENT_SOURCE_DIR}/local-engine -regex '.*\.\(c\|cpp\|h\)' -exec clang-format-15 --verbose -i --style=file -i {} \;)
+# execute_process(COMMAND find ${CMAKE_CURRENT_SOURCE_DIR}/local-engine -regex
+# '.*\.\(c\|cpp\|h\)' -exec clang-format-15 --verbose -i --style=file -i {} \;)
set(CH_BINARY_DIR "${CMAKE_CURRENT_SOURCE_DIR}/build")
option(ENABLE_CPP_TEST "Build CPP Unit test" OFF)
-if (ENABLE_CPP_TEST)
-add_custom_command(
- USES_TERMINAL
- COMMAND
- bash -c
- \"cmake -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
- -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
- -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
- -DENABLE_PROTOBUF=ON
- -DENABLE_TESTS=ON
- -DENABLE_JEMALLOC=ON
- -DENABLE_MULTITARGET_CODE=ON
- -DENABLE_EXTERN_LOCAL_ENGINE=ON
- -DCOMPILER_FLAGS='-fvisibility=hidden -fvisibility-inlines-hidden'
- -S ${CH_SOURCE_DIR} -G Ninja -B ${CH_BINARY_DIR} &&
- cmake --build ${CH_BINARY_DIR} --target ch unit_tests_local_engine\"
- OUTPUT _build_ch)
+if(ENABLE_CPP_TEST)
+ add_custom_command(
+ USES_TERMINAL
+ COMMAND
+ bash -c \"cmake -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
+ -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
+ -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DENABLE_PROTOBUF=ON
+ -DENABLE_TESTS=ON -DENABLE_JEMALLOC=ON -DENABLE_MULTITARGET_CODE=ON
+ -DENABLE_EXTERN_LOCAL_ENGINE=ON -DCOMPILER_FLAGS='-fvisibility=hidden
+ -fvisibility-inlines-hidden' -S ${CH_SOURCE_DIR} -G Ninja -B
+ ${CH_BINARY_DIR} && cmake --build ${CH_BINARY_DIR} --target ch
+ unit_tests_local_engine\"
+ OUTPUT _build_ch)
else()
-add_custom_command(
- USES_TERMINAL
- COMMAND
- bash -c
- \"cmake -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
- -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
- -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
- -DENABLE_PROTOBUF=ON
- -DENABLE_TESTS=OFF
- -DENABLE_JEMALLOC=ON
- -DENABLE_MULTITARGET_CODE=ON
- -DENABLE_EXTERN_LOCAL_ENGINE=ON
- -DENABLE_ODBC=OFF
- -DENABLE_CAPNP=OFF
- -DENABLE_ROCKSDB=OFF
- -DENABLE_GRPC=OFF
- -DENABLE_RUST=OFF
- -DENABLE_H3=OFF
- -DENABLE_AMQPCPP=OFF
- -DENABLE_CASSANDRA=OFF
- -DENABLE_KAFKA=OFF
- -DENABLE_NATS=OFF
- -DENABLE_LIBPQXX=OFF
- -DENABLE_NURAFT=OFF
- -DENABLE_DATASKETCHES=OFF
- -DENABLE_SQLITE=OFF
- -DENABLE_S2_GEOMETRY=OFF
- -DENABLE_ANNOY=OFF
- -DENABLE_ULID=OFF
- -DENABLE_MYSQL=OFF
- -DENABLE_BCRYPT=OFF
- -DENABLE_LDAP=OFF
- -DENABLE_MSGPACK=OFF
- -DUSE_REPLXX=OFF
- -DENABLE_CLICKHOUSE_ALL=OFF
- -DCOMPILER_FLAGS='-fvisibility=hidden -fvisibility-inlines-hidden'
- -S ${CH_SOURCE_DIR} -G Ninja -B ${CH_BINARY_DIR} &&
- cmake --build ${CH_BINARY_DIR} --target libch\"
- OUTPUT _build_ch)
+ add_custom_command(
Review Comment:
It seems to be getting messier here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "liuneng1994 (via GitHub)" <gi...@apache.org>.
liuneng1994 commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2154215349
> @liuneng1994, do you have any comment?
There is generally no problem, but subjectively, the effect of cmake-format seems to make some places more messy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144447027
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144525661
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144420661
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2154199654
@liuneng1994, do you have any comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#discussion_r1630946268
##########
cpp-ch/CMakeLists.txt:
##########
@@ -27,93 +29,93 @@ message("CH_COMMIT=${CH_COMMIT}")
project(libch LANGUAGES C CXX ASM)
file(GLOB clickhouse_files "${CH_SOURCE_DIR}/*")
-if ("${CH_SOURCE_DIR}" STREQUAL "${CMAKE_SOURCE_DIR}/ClickHouse")
- if (NOT clickhouse_files)
- execute_process(COMMAND git clone -b ${CH_BRANCH} --depth 3 https://github.com/${CH_ORG}/ClickHouse.git ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git reset --hard ${CH_COMMIT} WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git submodule update --init --force --depth 1 WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- else()
- execute_process(COMMAND git fetch origin ${CH_BRANCH} --depth 3 WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git checkout ${CH_BRANCH} WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git reset --hard ${CH_COMMIT} WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- execute_process(COMMAND git submodule update --init --recursive --force --depth 1 WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
- endif()
+if("${CH_SOURCE_DIR}" STREQUAL "${CMAKE_SOURCE_DIR}/ClickHouse")
+ if(NOT clickhouse_files)
+ execute_process(
+ COMMAND
+ git clone -b ${CH_BRANCH} --depth 3
+ https://github.com/${CH_ORG}/ClickHouse.git ${CH_SOURCE_DIR}
+ COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git reset --hard ${CH_COMMIT}
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git submodule update --init --force --depth 1
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ else()
+ execute_process(
+ COMMAND git fetch origin ${CH_BRANCH} --depth 3
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git checkout ${CH_BRANCH}
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git reset --hard ${CH_COMMIT}
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ execute_process(
+ COMMAND git submodule update --init --recursive --force --depth 1
+ WORKING_DIRECTORY ${CH_SOURCE_DIR} COMMAND_ERROR_IS_FATAL ANY)
+ endif()
else()
- if (NOT clickhouse_files)
- # Checking out *all* submodules takes > 5 min. Therefore, the smoke build ("FastTest") in CI initializes only the set of
- # submodules minimally needed for a build and we cannot assume here that all submodules are populated.
- message(ERROR "clickhouse ${CH_SOURCE_DIR} is missing or empty. to fix try run:")
- message(STATUS " git clone --recursive --depth 1 https://github.com/Kyligence/ClickHouse.git ${CMAKE_SOURCE_DIR}")
- endif()
+ if(NOT clickhouse_files)
+ # Checking out *all* submodules takes > 5 min. Therefore, the smoke build
+ # ("FastTest") in CI initializes only the set of submodules minimally needed
+ # for a build and we cannot assume here that all submodules are populated.
+ message(ERROR
+ "clickhouse ${CH_SOURCE_DIR} is missing or empty. to fix try run:")
+ message(
+ STATUS
+ " git clone --recursive --depth 1 https://github.com/Kyligence/ClickHouse.git ${CMAKE_SOURCE_DIR}"
+ )
+ endif()
endif()
-if (EXISTS "${CH_SOURCE_DIR}/utils/extern-local-engine")
- execute_process(COMMAND rm -rf ${CH_SOURCE_DIR}/utils/extern-local-engine)
-endif ()
-execute_process(COMMAND ln -s ${CMAKE_CURRENT_SOURCE_DIR}/local-engine ${CH_SOURCE_DIR}/utils/extern-local-engine COMMAND_ERROR_IS_FATAL ANY)
+if(EXISTS "${CH_SOURCE_DIR}/utils/extern-local-engine")
+ execute_process(COMMAND rm -rf ${CH_SOURCE_DIR}/utils/extern-local-engine)
+endif()
+execute_process(
+ COMMAND ln -s ${CMAKE_CURRENT_SOURCE_DIR}/local-engine
+ ${CH_SOURCE_DIR}/utils/extern-local-engine COMMAND_ERROR_IS_FATAL ANY)
-# execute_process(COMMAND find ${CMAKE_CURRENT_SOURCE_DIR}/local-engine -regex '.*\.\(c\|cpp\|h\)' -exec clang-format-15 --verbose -i --style=file -i {} \;)
+# execute_process(COMMAND find ${CMAKE_CURRENT_SOURCE_DIR}/local-engine -regex
+# '.*\.\(c\|cpp\|h\)' -exec clang-format-15 --verbose -i --style=file -i {} \;)
set(CH_BINARY_DIR "${CMAKE_CURRENT_SOURCE_DIR}/build")
option(ENABLE_CPP_TEST "Build CPP Unit test" OFF)
-if (ENABLE_CPP_TEST)
-add_custom_command(
- USES_TERMINAL
- COMMAND
- bash -c
- \"cmake -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
- -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
- -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
- -DENABLE_PROTOBUF=ON
- -DENABLE_TESTS=ON
- -DENABLE_JEMALLOC=ON
- -DENABLE_MULTITARGET_CODE=ON
- -DENABLE_EXTERN_LOCAL_ENGINE=ON
- -DCOMPILER_FLAGS='-fvisibility=hidden -fvisibility-inlines-hidden'
- -S ${CH_SOURCE_DIR} -G Ninja -B ${CH_BINARY_DIR} &&
- cmake --build ${CH_BINARY_DIR} --target ch unit_tests_local_engine\"
- OUTPUT _build_ch)
+if(ENABLE_CPP_TEST)
+ add_custom_command(
+ USES_TERMINAL
+ COMMAND
+ bash -c \"cmake -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
+ -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
+ -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DENABLE_PROTOBUF=ON
+ -DENABLE_TESTS=ON -DENABLE_JEMALLOC=ON -DENABLE_MULTITARGET_CODE=ON
+ -DENABLE_EXTERN_LOCAL_ENGINE=ON -DCOMPILER_FLAGS='-fvisibility=hidden
+ -fvisibility-inlines-hidden' -S ${CH_SOURCE_DIR} -G Ninja -B
+ ${CH_BINARY_DIR} && cmake --build ${CH_BINARY_DIR} --target ch
+ unit_tests_local_engine\"
+ OUTPUT _build_ch)
else()
-add_custom_command(
- USES_TERMINAL
- COMMAND
- bash -c
- \"cmake -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
- -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
- -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
- -DENABLE_PROTOBUF=ON
- -DENABLE_TESTS=OFF
- -DENABLE_JEMALLOC=ON
- -DENABLE_MULTITARGET_CODE=ON
- -DENABLE_EXTERN_LOCAL_ENGINE=ON
- -DENABLE_ODBC=OFF
- -DENABLE_CAPNP=OFF
- -DENABLE_ROCKSDB=OFF
- -DENABLE_GRPC=OFF
- -DENABLE_RUST=OFF
- -DENABLE_H3=OFF
- -DENABLE_AMQPCPP=OFF
- -DENABLE_CASSANDRA=OFF
- -DENABLE_KAFKA=OFF
- -DENABLE_NATS=OFF
- -DENABLE_LIBPQXX=OFF
- -DENABLE_NURAFT=OFF
- -DENABLE_DATASKETCHES=OFF
- -DENABLE_SQLITE=OFF
- -DENABLE_S2_GEOMETRY=OFF
- -DENABLE_ANNOY=OFF
- -DENABLE_ULID=OFF
- -DENABLE_MYSQL=OFF
- -DENABLE_BCRYPT=OFF
- -DENABLE_LDAP=OFF
- -DENABLE_MSGPACK=OFF
- -DUSE_REPLXX=OFF
- -DENABLE_CLICKHOUSE_ALL=OFF
- -DCOMPILER_FLAGS='-fvisibility=hidden -fvisibility-inlines-hidden'
- -S ${CH_SOURCE_DIR} -G Ninja -B ${CH_BINARY_DIR} &&
- cmake --build ${CH_BINARY_DIR} --target libch\"
- OUTPUT _build_ch)
+ add_custom_command(
Review Comment:
@liuneng1994, I think for most code, the formatting makes code look better. Maybe, some configuration can be applied in the future to tune the format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144384931
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144436270
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144609194
I tried to put code format check for cpp/cpp-ch together and then will remove `ch_code_style.yml`. But it's strange that if we do that (i.e., by removing https://github.com/apache/incubator-gluten/pull/5941/commits/200e183a624f405e96709510c267aea91bc0b459), clang-format will report some error for some CH code.
See https://github.com/apache/incubator-gluten/actions/runs/9346082625/job/25720197384.
And I tried to use clang-format-15 in local, same error is reported. @liuneng1994, could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144516071
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [WIP] Add CMake format checker [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2144389293
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2154008750
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CI] Add CMake format check [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp commented on PR #5941:
URL: https://github.com/apache/incubator-gluten/pull/5941#issuecomment-2146385017
@liuneng1994 @baibaichen please help to review and check, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org