[jira] [Commented] (YARN-2757) potential NPE in checkNodeLabelExpression of SchedulerUtils for nodeLabels.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186207#comment-14186207 ] 

Hadoop QA commented on YARN-2757:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12677472/YARN-2757.000.patch
  against trunk revision 00b4e44.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5593//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5593//console

This message is automatically generated.

> potential NPE in checkNodeLabelExpression of SchedulerUtils for nodeLabels.
> ---------------------------------------------------------------------------
>
>                 Key: YARN-2757
>                 URL: https://issues.apache.org/jira/browse/YARN-2757
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2757.000.patch
>
>
> pontential NPE in checkNodeLabelExpression of SchedulerUtils for nodeLabels.
> since we check the nodeLabels null at 
> {code}
>         if (!str.trim().isEmpty()
>             && (nodeLabels == null || !nodeLabels.contains(str.trim()))) {
>           return false;
>         }
> {code}
> We should also check nodeLabels null at 
> {code}
>       if (!nodeLabels.isEmpty()) {
>         return false;
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)