You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/22 19:35:46 UTC
[GitHub] [beam] kennknowles opened a new pull request #12338: [BEAM-10556] Add flag to ignore rawtype errors and add to modules
kennknowles opened a new pull request #12338:
URL: https://github.com/apache/beam/pull/12338
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robinyqiu commented on pull request #12338: [BEAM-10556] Add flag to ignore rawtype errors and add to modules
Posted by GitBox <gi...@apache.org>.
robinyqiu commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-662689283
What's the reason to turn off the rawtype error checks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-662810260
run java precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663095825
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663717275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663605877
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663263325
Tried just running precommit locally and publishing a scan. See a timeout (flake?) in Euphoria tests: https://scans.gradle.com/s/gx3exaswuez5w/tests/:sdks:java:extensions:euphoria:test/org.apache.beam.sdk.extensions.euphoria.core.translate.TimestampExtractTransformTest/testTransform#1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663797948
Noting that this is green and the conflicts in `sdks/java/extensions/sketching/build.gradle` are just two adjacent edits to the parameters to `applyJavaNature`. Since this PR is essentially trivial and has been held up by flakes and conflicts, I intend to merge it after resolving the conflict and confirming that `compileJava compileTestJava` succeeds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663731165
Ah, finally green, except :sdks:java:io:azure was added and it has rawtype errors and needs disabling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Add flag to ignore rawtype errors and add to modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-662715328
All the modules where it is disabled have rawtype usage, so it must first be fixed before the error can be turned on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663669320
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663239945
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663165549
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Add flag to ignore rawtype errors and add to modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-662718913
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663250011
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663707257
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Add flag to ignore rawtype errors and add to modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-662718204
I should have clarified: after this PR, the default is that rawtypes will break the build. So new modules will not have them. Existing modules have them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-662788906
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663758307
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #12338: [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors.
Posted by GitBox <gi...@apache.org>.
kennknowles merged pull request #12338:
URL: https://github.com/apache/beam/pull/12338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12338: [BEAM-10556] Add flag to ignore rawtype errors and add to modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-662719002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org