You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rafaelweingartner <gi...@git.apache.org> on 2015/08/30 01:38:22 UTC
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
GitHub user rafaelweingartner opened a pull request:
https://github.com/apache/cloudstack/pull/762
Proposal for an improved CglibThrowableRenderer
Following our discussions on mailing list, here is a PR with a proposal for an improvement on “CglibThrowableRenderer”. We would still have to define a number to limit the stack traces of causes (I randomly chose 3, just to get the code running). The test case is also not good in my opinion, but I ran out of ideas (waiting for suggestions on that).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack cglibThrowableRenderer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #762
----
commit d9515da9a605f4648bd25258ade339637f14bd4f
Author: weingartner <ra...@gmail.com>
Date: 2015-08-29T23:35:13Z
Proposal for an improved CglibThrowableRenderer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136132050
Does anyone else have some ideas on how to test that code?
I am not comfortable with the test I coded, the test feels shallow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136702586
With your comments, I fixed my Eclipse configuration on my Windows
environment, now I am using UNIX lines for ACS on windows.
On Tue, Sep 1, 2015 at 9:33 AM, Rajani Karuturi <no...@github.com>
wrote:
> cat -v filename will show you line endings.
> I figured the timezone issue. didnt want to wait for another day with
> broken build. hence pushed it.
> The recent build passed. Thanks :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/762#issuecomment-136698602>.
>
--
Rafael Weingärtner
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136599746
@rafaelweingartner I see windows line endings in the new test file. Can you fix that please?
Other than that, LGTM. once thats fixed I will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136106558
LGTM, reviewing this I finally understand why we have a custom renderer at all. The travis failing checks are unrelated timeouts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136640347
since this fixes slow build, I am going to merge this PR and push another commit for line endings fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136363041
The tests that have failed do not seem to be related to the code that was changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136698602
cat -v filename will show you line endings.
I figured the timezone issue. didnt want to wait for another day with broken build. hence pushed it.
The recent build passed. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136686182
@Karuturi, Sorry for the windows line endings (did you see that on log files? I was not able to see anything there). Sometimes I jump between OS and forget that I am coding from a Windows machine, instead of my usual Ubuntu.
BTW: I think we are in very different time zones, I just woke up. Thanks for the windows line fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---