You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <jo...@gmail.com> on 2015/11/19 05:57:01 UTC
Re: Review Request 32302: Allow config to specify static ports for
non-dedicated jobs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32302/#review107133
-----------------------------------------------------------
Brian - can you add specific reviewers to the `People` field or else discard?
@ReviewBot retry
- John Sirois
On March 20, 2015, 6:30 a.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32302/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 6:30 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1212
> https://issues.apache.org/jira/browse/AURORA-1212
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Currently the client allows static ports only for dedicated jobs,
> the scheduler has no such restirction. Remove this restriction.
>
> The docs make no mention of this limition, so no changes are
> required there.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 59703ef
> src/test/python/apache/aurora/client/test_config.py c567797
>
> Diff: https://reviews.apache.org/r/32302/diff/
>
>
> Testing
> -------
>
> Ran unittests and created a non-dedicated job with a static port in vagrant enviroment.
>
>
> Thanks,
>
> Brian Brazil
>
>