Re: [PR] GH-50212: [C++] add PrintTo to fix failure in parquet-internals-test on test-conda-cpp-valgrind [arrow]

["tadeja (via GitHub)" <gi...@apache.org>]

tadeja commented on code in PR #50213:
URL: https://github.com/apache/arrow/pull/50213#discussion_r3431195583


##########
cpp/src/parquet/bloom_filter_reader_writer_test.cc:
##########
@@ -159,6 +159,12 @@ struct BloomFilterBuilderFoldingTestCase {
   int64_t expected_bitset_ndv;
 };
 
+void PrintTo(const BloomFilterBuilderFoldingTestCase& test_case, std::ostream* os) {
+  *os << "{ndv=" << test_case.ndv << ", fold=" << test_case.fold
+      << ", inserted_count=" << test_case.inserted_count
+      << ", expected_bitset_ndv=" << test_case.expected_bitset_ndv << "}";

Review Comment:
   Alternative shorter fix like the old fix in commit 1b7e3967 but with less debug output
   ```suggestion
   void PrintTo(const BloomFilterBuilderFoldingTestCase& c, std::ostream* os) {
     *os << "BloomFilterBuilderFoldingTestCase(" << reinterpret_cast<const void*>(&c)
            << ")";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org