You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/10/13 21:12:08 UTC
Review Request 26656: hive configuration - remove disabling of
fs.cache
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26656/
-----------------------------------------------------------
Review request for Ambari, Jeff Sposetti and Vitalyi Brodetskyi.
Bugs: AMBARI-7763
https://issues.apache.org/jira/browse/AMBARI-7763
Repository: ambari
Description
-------
fs.hdfs.impl.disable.cache and fs.file.impl.disable.cache were being set to true to workaround some memory leaks. The memory leak has now been fixed.
For champlain and newer versions of hive, we should stop setting these to true. Ideally, we should just leave them unset, so that the default values (false) gets used.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml c1e8fa6
Diff: https://reviews.apache.org/r/26656/diff/
Testing
-------
not applicable
Thanks,
Dmitro Lisnichenko
Re: Review Request 26656: hive configuration - remove disabling of
fs.cache
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26656/#review56542
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Жов. 13, 2014, 7:12 після полудня, Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26656/
> -----------------------------------------------------------
>
> (Updated Жов. 13, 2014, 7:12 після полудня)
>
>
> Review request for Ambari, Jeff Sposetti and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7763
> https://issues.apache.org/jira/browse/AMBARI-7763
>
>
> Repository: ambari
>
>
> Description
> -------
>
> fs.hdfs.impl.disable.cache and fs.file.impl.disable.cache were being set to true to workaround some memory leaks. The memory leak has now been fixed.
> For champlain and newer versions of hive, we should stop setting these to true. Ideally, we should just leave them unset, so that the default values (false) gets used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml c1e8fa6
>
> Diff: https://reviews.apache.org/r/26656/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26656: hive configuration - remove disabling of
fs.cache
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26656/#review56543
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Oct. 14, 2014, 4:47 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26656/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 4:47 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7763
> https://issues.apache.org/jira/browse/AMBARI-7763
>
>
> Repository: ambari
>
>
> Description
> -------
>
> fs.hdfs.impl.disable.cache and fs.file.impl.disable.cache were being set to true to workaround some memory leaks. The memory leak has now been fixed.
> For champlain and newer versions of hive, we should stop setting these to true. Ideally, we should just leave them unset, so that the default values (false) gets used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml c1e8fa6
>
> Diff: https://reviews.apache.org/r/26656/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26656: hive configuration - remove disabling of
fs.cache
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26656/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 4:47 p.m.)
Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
Bugs: AMBARI-7763
https://issues.apache.org/jira/browse/AMBARI-7763
Repository: ambari
Description
-------
fs.hdfs.impl.disable.cache and fs.file.impl.disable.cache were being set to true to workaround some memory leaks. The memory leak has now been fixed.
For champlain and newer versions of hive, we should stop setting these to true. Ideally, we should just leave them unset, so that the default values (false) gets used.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml c1e8fa6
Diff: https://reviews.apache.org/r/26656/diff/
Testing
-------
not applicable
Thanks,
Dmitro Lisnichenko