You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/27 07:03:26 UTC
[GitHub] [skywalking-eyes] xiaoyawei opened a new pull request, #142: fix license header normalizer
xiaoyawei opened a new pull request, #142:
URL: https://github.com/apache/skywalking-eyes/pull/142
## Why do we need this fix?
As we are using `license-eyes` to check license header in our open-sourced projects, we notice that it can help detect
unexpected changes in the license header, *except the copyright line*. In my opinion, it's also necessary to protect the copyright line from unintentional changes.
## How was this issue introduced?
https://github.com/apache/skywalking-eyes/pull/46 introduced this line processor to ignore copyright line, mostly for the purpose of dependency resolution. However, in https://github.com/apache/skywalking-eyes/pull/107 starts using Google's license check for this purpose, and this line processor only works to ignore copyright line when checking / fixing license header.
## Reviewer
@kezhenxu94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 merged pull request #142: fix license header normalizer
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #142:
URL: https://github.com/apache/skywalking-eyes/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] tisonkun commented on pull request #142: fix license header normalizer
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #142:
URL: https://github.com/apache/skywalking-eyes/pull/142#issuecomment-1295735547
@kezhenxu94 fair enough. Apply and fix the issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #142: fix license header normalizer
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #142:
URL: https://github.com/apache/skywalking-eyes/pull/142#issuecomment-1294571218
I knew this was a breaking change, but it breaks something that was wrongly configured, and the previous successful CI should have been failed.
In your case, using spdx-id whose content has variables should be substituted, so you might need to provide `copyright-owner`, I know that also failed because of a bug https://github.com/apache/skywalking-eyes/pull/143, the variables are not substituted previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] tisonkun commented on pull request #142: fix license header normalizer
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #142:
URL: https://github.com/apache/skywalking-eyes/pull/142#issuecomment-1294530307
This commit causes a previously passed CI to fail. You may re-check the diff: https://github.com/tisonkun/failpoints/actions/runs/3342840329/jobs/5535474781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] xiaoyawei commented on pull request #142: fix license header normalizer
Posted by GitBox <gi...@apache.org>.
xiaoyawei commented on PR #142:
URL: https://github.com/apache/skywalking-eyes/pull/142#issuecomment-1294560196
@tisonkun your CI failures look reasonable to me: its copyright line in license header does not match the specs in https://github.com/tisonkun/failpoints/blob/main/tools/ci/licenserc.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #142: fix license header normalizer
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #142:
URL: https://github.com/apache/skywalking-eyes/pull/142#issuecomment-1294573292
@tisonkun with #143 and the following patch to your repo, CI should pass
```diff
diff --git a/tools/ci/licenserc.yml b/tools/ci/licenserc.yml
index 7122e11..2c56a5d 100644
--- a/tools/ci/licenserc.yml
+++ b/tools/ci/licenserc.yml
@@ -15,6 +15,7 @@
header:
license:
spdx-id: Apache-2.0
+ copyright-owner: tison <wa...@gmail.com>
paths:
- '**/*.java'
- '**/*.yml'
```
Let me know if that fix makes sense to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org