You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/07/28 03:14:53 UTC
Re: Review Request 36832: SENTRY-813: Refactor the
AuditMetadataLogEntity to support the audit log for generic mdoel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36832/
-----------------------------------------------------------
(Updated July 28, 2015, 1:14 a.m.)
Review request for sentry, Dapeng Sun and shen guoquan.
Summary (updated)
-----------------
SENTRY-813: Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel
Repository: sentry
Description
-------
Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java 6b63045
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/HiveAuditMetadataLogEntity.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestAuditMetadataLogEntity.java 95b51e9
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java PRE-CREATION
Diff: https://reviews.apache.org/r/36832/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 36832: SENTRY-813: Refactor the
AuditMetadataLogEntity to support the audit log for generic mdoel
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36832/#review95825
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java (line 29)
<https://reviews.apache.org/r/36832/#comment150969>
This class name should be **TestDBAuditMetadataLogEntity**
Most looks good to me, one minor comment left
- Dapeng Sun
On 八月 13, 2015, 1:11 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36832/
> -----------------------------------------------------------
>
> (Updated 八月 13, 2015, 1:11 p.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java 6b63045
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestAuditMetadataLogEntity.java 95b51e9
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36832/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 36832: SENTRY-813: Refactor the
AuditMetadataLogEntity to support the audit log for generic mdoel
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36832/#review100345
-----------------------------------------------------------
Ship it!
Ship It!
- Dapeng Sun
On 八月 13, 2015, 1:11 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36832/
> -----------------------------------------------------------
>
> (Updated 八月 13, 2015, 1:11 p.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java 6b63045
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestAuditMetadataLogEntity.java 95b51e9
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36832/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 36832: SENTRY-813: Refactor the
AuditMetadataLogEntity to support the audit log for generic mdoel
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36832/
-----------------------------------------------------------
(Updated Aug. 13, 2015, 5:11 a.m.)
Review request for sentry, Dapeng Sun and shen guoquan.
Repository: sentry
Description
-------
Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java 6b63045
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestAuditMetadataLogEntity.java 95b51e9
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java PRE-CREATION
Diff: https://reviews.apache.org/r/36832/diff/
Testing
-------
Thanks,
Colin Ma