You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by da...@apache.org on 2013/05/14 20:14:47 UTC
svn commit: r1482510 - in /pig/trunk: CHANGES.txt
test/org/apache/pig/test/TestExampleGenerator.java
Author: daijy
Date: Tue May 14 18:14:47 2013
New Revision: 1482510
URL: http://svn.apache.org/r1482510
Log:
PIG-3291: TestExampleGenerator fails on Windows because of lack of file name escaping
Modified:
pig/trunk/CHANGES.txt
pig/trunk/test/org/apache/pig/test/TestExampleGenerator.java
Modified: pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/trunk/CHANGES.txt?rev=1482510&r1=1482509&r2=1482510&view=diff
==============================================================================
--- pig/trunk/CHANGES.txt (original)
+++ pig/trunk/CHANGES.txt Tue May 14 18:14:47 2013
@@ -178,6 +178,8 @@ PIG-3013: BinInterSedes improve chararra
BUG FIXES
+PIG-3291: TestExampleGenerator fails on Windows because of lack of file name escaping (dwann via daijy)
+
PIG-3026: Pig checked-in baseline comparisons need a pre-filter to address OS-specific newline differences (dwann via daijy)
PIG-3025: TestPruneColumn unit test - SimpleEchoStreamingCommand perl inline script needs simplification (dwann via daijy)
Modified: pig/trunk/test/org/apache/pig/test/TestExampleGenerator.java
URL: http://svn.apache.org/viewvc/pig/trunk/test/org/apache/pig/test/TestExampleGenerator.java?rev=1482510&r1=1482509&r2=1482510&view=diff
==============================================================================
--- pig/trunk/test/org/apache/pig/test/TestExampleGenerator.java (original)
+++ pig/trunk/test/org/apache/pig/test/TestExampleGenerator.java Tue May 14 18:14:47 2013
@@ -59,8 +59,8 @@ public class TestExampleGenerator {
fileA.deleteOnExit();
fileB.deleteOnExit();
- A = "'" + fileA.getPath() + "'";
- B = "'" + fileB.getPath() + "'";
+ A = Util.encodeEscape("'" + fileA.getPath() + "'");
+ B = Util.encodeEscape("'" + fileB.getPath() + "'");
System.out.println("A : " + A + "\n" + "B : " + B);
System.out.println("Test data created.");
}
@@ -390,7 +390,7 @@ public class TestExampleGenerator {
pigServer.registerQuery("B = filter A by x < 5;");
pigServer.registerQuery("C = group B by x;");
pigServer.registerQuery("D = foreach C generate group as x, COUNT(B) as the_count;");
- pigServer.registerQuery("store D into '" + out.getAbsolutePath() + "';");
+ pigServer.registerQuery("store D into '" + Util.encodeEscape(out.getAbsolutePath()) + "';");
Map<Operator, DataBag> derivedData = pigServer.getExamples(null);
assertNotNull(derivedData);