You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/14 03:22:00 UTC

Review Request: Fixed Duration's stream insertion operator so that the output string does not have trailing zeros after the decimal point. (libstout)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11134/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp 421615aa510f540ccfc0413d3252bbdedd70f7da 

Diff: https://reviews.apache.org/r/11134/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request: Fixed Duration's stream insertion operator so that the output string does not have trailing zeros after the decimal point. (libstout)

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11134/#review20609
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 14, 2013, 8:07 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11134/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 8:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary. [Part 1 of Duration-Time Refactoring Chain]
> 
> - No need to use the fixed format.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577 
>   third_party/libprocess/third_party/stout/tests/duration_tests.cpp 421615aa510f540ccfc0413d3252bbdedd70f7da 
> 
> Diff: https://reviews.apache.org/r/11134/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request: Fixed Duration's stream insertion operator so that the output string does not have trailing zeros after the decimal point. (libstout)

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11134/
-----------------------------------------------------------

(Updated May 14, 2013, 8:07 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description (updated)
-------

See summary. [Part 1 of Duration-Time Refactoring Chain]

- No need to use the fixed format.


Diffs
-----

  third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp 421615aa510f540ccfc0413d3252bbdedd70f7da 

Diff: https://reviews.apache.org/r/11134/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu