You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/16 01:57:52 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11953: Fix alert_send_status may throw duplicate key exception and add limit for query alert

ruanwenjun commented on code in PR #11953:
URL: https://github.com/apache/dolphinscheduler/pull/11953#discussion_r972545402


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertSendStatus.java:
##########
@@ -69,20 +74,4 @@ public class AlertSendStatus {
     @TableField("create_time")
     private Date createTime;
 
-    @Override

Review Comment:
   I find we didn't use the equals method, I worry the old equals is incorrect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org