You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/11/24 11:03:45 UTC
Review Request 40633: LENS-878 : Refactor inner classes in
JoinResolver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40633/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-878
https://issues.apache.org/jira/browse/LENS-878
Repository: lens
Description
-------
Only refactoring, no code changes
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java a660133
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a916159
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 8a84249
Diff: https://reviews.apache.org/r/40633/diff/
Testing
-------
lens-cube tests pass, except TestCubeMetastoreClient.testCubeDim(tracked in LENS-865) and all checkstyle and rat-check pass
Thanks,
Amareshwari Sriramadasu
Re: Review Request 40633: LENS-878 : Refactor inner classes in
JoinResolver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40633/#review107749
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java (lines 93 - 107)
<https://reviews.apache.org/r/40633/#comment167032>
Looks like formatting messed up the documentation.
- Rajat Khandelwal
On Nov. 24, 2015, 3:33 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40633/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 3:33 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-878
> https://issues.apache.org/jira/browse/LENS-878
>
>
> Repository: lens
>
>
> Description
> -------
>
> Only refactoring, no code changes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java a660133
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a916159
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 8a84249
>
> Diff: https://reviews.apache.org/r/40633/diff/
>
>
> Testing
> -------
>
> lens-cube tests pass, except TestCubeMetastoreClient.testCubeDim(tracked in LENS-865) and all checkstyle and rat-check pass
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 40633: LENS-878 : Refactor inner classes in
JoinResolver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 25, 2015, 8:34 a.m., Rajat Khandelwal wrote:
> > Ship It!
>
> Rajat Khandelwal wrote:
> All tests pass now?
Yes. Run on pre-commt job at https://issues.apache.org/jira/browse/LENS-878
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40633/#review107941
-----------------------------------------------------------
On Nov. 24, 2015, 10:27 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40633/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 10:27 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-878
> https://issues.apache.org/jira/browse/LENS-878
>
>
> Repository: lens
>
>
> Description
> -------
>
> Only refactoring, no code changes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java a660133
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a916159
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 8a84249
>
> Diff: https://reviews.apache.org/r/40633/diff/
>
>
> Testing
> -------
>
> lens-cube tests pass, except TestCubeMetastoreClient.testCubeDim(tracked in LENS-865) and all checkstyle and rat-check pass
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 40633: LENS-878 : Refactor inner classes in
JoinResolver
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 25, 2015, 2:04 p.m., Rajat Khandelwal wrote:
> > Ship It!
All tests pass now?
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40633/#review107941
-----------------------------------------------------------
On Nov. 24, 2015, 3:57 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40633/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-878
> https://issues.apache.org/jira/browse/LENS-878
>
>
> Repository: lens
>
>
> Description
> -------
>
> Only refactoring, no code changes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java a660133
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a916159
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 8a84249
>
> Diff: https://reviews.apache.org/r/40633/diff/
>
>
> Testing
> -------
>
> lens-cube tests pass, except TestCubeMetastoreClient.testCubeDim(tracked in LENS-865) and all checkstyle and rat-check pass
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 40633: LENS-878 : Refactor inner classes in
JoinResolver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40633/#review107941
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Nov. 24, 2015, 3:57 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40633/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-878
> https://issues.apache.org/jira/browse/LENS-878
>
>
> Repository: lens
>
>
> Description
> -------
>
> Only refactoring, no code changes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java a660133
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a916159
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 8a84249
>
> Diff: https://reviews.apache.org/r/40633/diff/
>
>
> Testing
> -------
>
> lens-cube tests pass, except TestCubeMetastoreClient.testCubeDim(tracked in LENS-865) and all checkstyle and rat-check pass
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 40633: LENS-878 : Refactor inner classes in
JoinResolver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40633/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 10:27 a.m.)
Review request for lens.
Changes
-------
Updated doc
Bugs: LENS-878
https://issues.apache.org/jira/browse/LENS-878
Repository: lens
Description
-------
Only refactoring, no code changes
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java a660133
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a916159
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 8a84249
Diff: https://reviews.apache.org/r/40633/diff/
Testing
-------
lens-cube tests pass, except TestCubeMetastoreClient.testCubeDim(tracked in LENS-865) and all checkstyle and rat-check pass
Thanks,
Amareshwari Sriramadasu