[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #315: Incremental processing implementation

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #315: Incremental processing implementation
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r373745346
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
 ##########
 @@ -21,27 +21,36 @@
 
 import com.github.benmanes.caffeine.cache.Caffeine;
 import com.github.benmanes.caffeine.cache.LoadingCache;
-import com.google.common.collect.ImmutableList;
+import com.google.common.base.Predicate;
+import com.google.common.base.Predicates;
 
 Review comment:
   The main factor in not using Guava functions is that we don't want to leak Guava in the Iceberg API. That means where we accept functions, we should use the ones from `java.util.function`. From there, I don't think it is a good idea to mix two nearly identical but different interfaces in separate parts of the code.
   
   It's not too bad to adapt the standard Java interfaces to Guava. Usually it's just a matter of passing `javaFunc::apply`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org