You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/05/02 02:02:45 UTC
Review Request 58902: Changed containerizer->launch callsites to new
interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58902/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
As part of combining the two `containerizer->launch` code paths,
callers now need to construct the `ContainerConfig` (instead of
passing some fields that are then copied into a `ContainerConfig`).
Diffs
-----
src/slave/http.cpp 2ce345d9958a867ece835e47287215cefd561abf
src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
Diff: https://reviews.apache.org/r/58902/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 58902: Changed containerizer->launch callsites to
new interface.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58902/#review174634
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 2, 2017, 2:02 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58902/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 2:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As part of combining the two `containerizer->launch` code paths,
> callers now need to construct the `ContainerConfig` (instead of
> passing some fields that are then copied into a `ContainerConfig`).
>
>
> Diffs
> -----
>
> src/slave/http.cpp 2ce345d9958a867ece835e47287215cefd561abf
> src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
>
>
> Diff: https://reviews.apache.org/r/58902/diff/1/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>