You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/05/20 20:08:46 UTC

Review Request 21720: Updated metric names for consistency.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21720/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-1332
    https://issues.apache.org/jira/browse/MESOS-1332


Repository: mesos-git


Description
-------

see summary


Diffs
-----

  src/master/master.hpp 5e0d712de997bd10079655df9b07099284f8257f 
  src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673 
  src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e 
  src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7 
  src/tests/master_tests.cpp 1ea1da685420aeee4cbed4765d7cfdf31fc7231f 
  src/tests/slave_tests.cpp 85ca5c41bfafe4f932ea51b4fb9654b2fc828232 

Diff: https://reviews.apache.org/r/21720/diff/


Testing
-------

make check


Thanks,

Dominic Hamon

Re: Review Request 21720: Updated metric names for consistency.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21720/
-----------------------------------------------------------

(Updated May 27, 2014, 3:06 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

rebased


Bugs: MESOS-1332
    https://issues.apache.org/jira/browse/MESOS-1332


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  src/master/master.hpp 847d7c7a585887ffb31566ade7bf134591521843 
  src/master/master.cpp ae738bb790f1887d62d8eed8de44536ca3b4c498 
  src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e 
  src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7 
  src/tests/master_tests.cpp b0e05de9a7226ee330007a3f3fe71976fb0748d6 
  src/tests/slave_tests.cpp 85ca5c41bfafe4f932ea51b4fb9654b2fc828232 

Diff: https://reviews.apache.org/r/21720/diff/


Testing
-------

make check


Thanks,

Dominic Hamon

Re: Review Request 21720: Updated metric names for consistency.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21720/#review44001
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 20, 2014, 6:08 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21720/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 6:08 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1332
>     https://issues.apache.org/jira/browse/MESOS-1332
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5e0d712de997bd10079655df9b07099284f8257f 
>   src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673 
>   src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e 
>   src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7 
>   src/tests/master_tests.cpp 1ea1da685420aeee4cbed4765d7cfdf31fc7231f 
>   src/tests/slave_tests.cpp 85ca5c41bfafe4f932ea51b4fb9654b2fc828232 
> 
> Diff: https://reviews.apache.org/r/21720/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>