You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2023/01/07 19:53:23 UTC

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #545: feat(plc4go): Implementing the correct reading of BOOL types

chrisdutz commented on code in PR #545:
URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040681


##########
plc4go/examples/read/hello_world_plc4go_read.go:
##########
@@ -31,7 +31,7 @@ func main() {
 	drivers.RegisterModbusTcpDriver(driverManager)
 
 	// Get a connection to a remote PLC
-	crc := driverManager.GetConnection("modbus-tcp://192.168.23.30")
+	crc := driverManager.GetConnection("modbus-tcp://192.168.10.180")

Review Comment:
   We should probably externalize this because every one is probably going to have the device at a different IP



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org