[GitHub] [solr] cpoerschke commented on a diff in pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

["cpoerschke (via GitHub)" <gi...@apache.org>]

cpoerschke commented on code in PR #1622:
URL: https://github.com/apache/solr/pull/1622#discussion_r1185833612


##########
solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java:
##########
@@ -60,7 +60,6 @@ public class ResponseBuilder {
   public boolean doExpand;
   public boolean doStats;
   public boolean doTerms;
-  public boolean doAnalytics;

Review Comment:
   observation only and I am not aware of such a use case: if someone wanted to take the removed analytics module code and have it locally or as a package plugin or so then the removal of the `ResponseBuilder` members and setter/getters here would present a small challenge. aside from patching the equivalent of what is removed here into a local variant of the `ResponseBuilder`, it's possible to have a custom response builder and the notes on the https://issues.apache.org/jira/browse/SOLR-13511 illustrate how a custom response builder/custom search handler combination can be done and configured.



##########
solr/solr-ref-guide/modules/query-guide/pages/analytics-expression-sources.adoc:
##########
@@ -1,95 +0,0 @@
-= Analytics Expression Sources

Review Comment:
   Via `git grep` found "analytics" references in `dev-tools` e.g. https://github.com/apache/solr/blob/df84356a816442c6b2a7b578cb193f22b418cdae/dev-tools/scripts/refguide/new-guide.txt#L75 though not sure if the tooling would automatically handle that i.e. maybe no change needed there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org