You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/04/25 19:50:34 UTC
Review Request 46648: Add show_available property to dry_run directive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46648/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-16096
https://issues.apache.org/jira/browse/AMBARI-16096
Repository: ambari
Description
-------
When POSTing with dry_run=true, and the POST is for a publicly available VDF, then return the show_available property in the response.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java a78af6e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java c9fa9a3
Diff: https://reviews.apache.org/r/46648/diff/
Testing
-------
Manual. Automated:
Tests run: 4257, Failures: 0, Errors: 0, Skipped: 32
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:18.070s
[INFO] Finished at: Mon Apr 25 13:48:39 EDT 2016
[INFO] Final Memory: 35M/590M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 46648: Add show_available property to dry_run
directive
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
> On April 25, 2016, 5:51 p.m., Zhe (Joe) Wang wrote:
> > Ship It!
Works as FE expects.
- Zhe (Joe)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46648/#review130475
-----------------------------------------------------------
On April 25, 2016, 5:50 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46648/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 5:50 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-16096
> https://issues.apache.org/jira/browse/AMBARI-16096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When POSTing with dry_run=true, and the POST is for a publicly available VDF, then return the show_available property in the response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java a78af6e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java c9fa9a3
>
> Diff: https://reviews.apache.org/r/46648/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> Tests run: 4257, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.070s
> [INFO] Finished at: Mon Apr 25 13:48:39 EDT 2016
> [INFO] Final Memory: 35M/590M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 46648: Add show_available property to dry_run
directive
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46648/#review130475
-----------------------------------------------------------
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 25, 2016, 5:50 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46648/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 5:50 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-16096
> https://issues.apache.org/jira/browse/AMBARI-16096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When POSTing with dry_run=true, and the POST is for a publicly available VDF, then return the show_available property in the response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java a78af6e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java c9fa9a3
>
> Diff: https://reviews.apache.org/r/46648/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> Tests run: 4257, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.070s
> [INFO] Finished at: Mon Apr 25 13:48:39 EDT 2016
> [INFO] Final Memory: 35M/590M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 46648: Add show_available property to dry_run
directive
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46648/#review130601
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 25, 2016, 1:50 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46648/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 1:50 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-16096
> https://issues.apache.org/jira/browse/AMBARI-16096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When POSTing with dry_run=true, and the POST is for a publicly available VDF, then return the show_available property in the response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java a78af6e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java c9fa9a3
>
> Diff: https://reviews.apache.org/r/46648/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> Tests run: 4257, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.070s
> [INFO] Finished at: Mon Apr 25 13:48:39 EDT 2016
> [INFO] Final Memory: 35M/590M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>